From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 87A541F4B5 for ; Tue, 12 Nov 2019 10:40:17 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; q=dns; s=default; b=QC1F01boh4cfKGF0DEbgVQ6hwaoGje2 6jSKRdvtJ3IeGA3Ono/qT19LTsOl+LijG8IJaOtqceXjZuZjtNAXefeokg8g4p1D lXIstIJWI2NH6ygmcLlSmMADkXQJO2tGh1+t80hboglE6uHsqzoxHbOtJmQVzs8c AH6cvsfFnr8Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:in-reply-to:references :reply-to:mime-version:content-transfer-encoding:content-type :message-id; s=default; bh=d47fF2jHpj448kSC+VnrY/IU35Y=; b=FCQq+ F8zKClBbPa2ClL2KsZvdyuEwqYI3aE6JhTpIcjfTvTIOKwWWSt+yEdOpEof4GhTw rmNuabwYQL9olwF7Sr3j0JF880qkQxD9fQVdcpsBc7JSdM8yddKGKZFgAikqo/02 QtUezHEud2wT3SHodAD1TlMd5XZudEKbOdiamU= Received: (qmail 25112 invoked by alias); 12 Nov 2019 10:40:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 25103 invoked by uid 89); 12 Nov 2019 10:40:14 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.osci.io X-Gerrit-PatchSet: 2 Date: Tue, 12 Nov 2019 05:40:08 -0500 From: "Szabolcs Nagy (Code Review)" To: Florian Weimer , libc-alpha@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25... X-Gerrit-Change-Id: I51be146a7857186a4ede0bb40b332509487bdde8 X-Gerrit-Change-Number: 489 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1c2704f7eb051fa2cba618126bd60803dff271df In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 05:40:08 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112104008.B3B3B20AF6@gnutoolchain-gerrit.osci.io> Szabolcs Nagy has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/489 ...................................................................... Patch Set 2: Code-Review+2 (2 comments) two nits, otherwise ok. | --- csu/libc-tls.c | +++ csu/libc-tls.c | @@ -199,18 +193,18 @@ #endif | /* Update the executable's link map with enough information to make | the TLS routines happy. */ | main_map->l_tls_align = align; | main_map->l_tls_blocksize = memsz; | main_map->l_tls_initimage = initimage; | main_map->l_tls_initimage_size = filesz; | main_map->l_tls_modid = 1; | | init_slotinfo (); | // static_slotinfo.si.slotinfo[1].gen = 0; already zero PS2, Line 202: .si in the comment is wrong | - static_slotinfo.si.slotinfo[1].map = main_map; | + static_slotinfo.slotinfo[1].map = main_map; | | memsz = roundup (memsz, align ?: 1); | | #if TLS_DTV_AT_TP | memsz += tcb_offset; | #endif | | --- nptl_db/db_info.c | +++ nptl_db/db_info.c | @@ -49,15 +49,18 @@ #define schedparam_sched_priority schedparam.sched_priority | | #define eventbuf_eventmask eventbuf.eventmask | #define eventbuf_eventmask_event_bits eventbuf.eventmask.event_bits | | #define DESC(name, offset, obj) \ | DB_DEFINE_DESC (name, 8 * sizeof (obj), 1, offset); | #define ARRAY_DESC(name, offset, obj) \ | DB_DEFINE_DESC (name, \ | - 8 * sizeof (obj)[0], sizeof (obj) / sizeof (obj)[0], \ | + 8 * sizeof (obj)[0], sizeof (obj) / sizeof (obj)[0], \ PS2, Line 57: is this whitespace change useful? | offset); | +/* Flexible arrays do not have a length that can be determined. */ | +#define FLEXIBLE_ARRAY_DESC(name, offset, obj) \ | + DB_DEFINE_DESC (name, 8 * sizeof (obj)[0], 0, offset); | | #if TLS_TCB_AT_TP | # define dtvp header.dtv | #elif TLS_DTV_AT_TP | /* Special case hack. If TLS_TCB_SIZE == 0 (on PowerPC), there is no TCB -- Gerrit-Project: glibc Gerrit-Branch: master Gerrit-Change-Id: I51be146a7857186a4ede0bb40b332509487bdde8 Gerrit-Change-Number: 489 Gerrit-PatchSet: 2 Gerrit-Owner: Florian Weimer Gerrit-Reviewer: Szabolcs Nagy Gerrit-Comment-Date: Tue, 12 Nov 2019 10:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment