From: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>
To: Florian Weimer <fweimer@redhat.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/6] ldbl-128ibm-compat: Add regular character printing functions
Date: Mon, 2 Sep 2019 11:03:21 -0300 [thread overview]
Message-ID: <20190902110321.48d0a1b2@tereshkova> (raw)
In-Reply-To: <20190815153021.40983ca5@tereshkova>
On Thu, 15 Aug 2019, Gabriel F. T. Gomes wrote:
>On Wed, 14 Aug 2019, Florian Weimer wrote:
>
>>Why isn't the assignment to obj-suf-foreach dead?
>
>Oh! There's a hunk missing in this patch. It should have the following
>extra statement:
>
>+$(call obj-suf-foreach,$(ldbl-ibm128-files)): \
>+ sysdep-CFLAGS += -mabi=ibmlongdouble
>
>I accidentally removed it when preparing the patch for submission. Sorry
>and thanks for catching it.
>
>It does not affect the test results because there's nothing currently
>adding -mabi=ieeelongdouble to the build of powerpc64le files. Anyway,
>I'll reinstate this hunk locally, because it makes it clear *and explicit*
>that these files must be built with -mabi=ibmlongdouble, regardless of
>what becomes the default (if the default changes).
Are you OK with this explanation (and amendment)? I like the idea of
making it explicit that -mabi=ibmlongdouble is required for these files.
next prev parent reply other threads:[~2019-09-02 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 18:31 [PATCH 0/6] IEEE long double printf and friends for powerpc64le Gabriel F. T. Gomes
2019-08-09 18:31 ` [PATCH 1/6] ldbl-128ibm-compat: Add regular character printing functions Gabriel F. T. Gomes
2019-08-14 11:46 ` Florian Weimer
2019-08-15 18:30 ` Gabriel F. T. Gomes
2019-09-02 14:03 ` Gabriel F. T. Gomes [this message]
2019-09-02 14:28 ` Florian Weimer
2019-09-02 15:11 ` Gabriel F. T. Gomes
2019-08-09 18:31 ` [PATCH 2/6] ldbl-128ibm-compat: Add wide " Gabriel F. T. Gomes
2019-08-09 18:31 ` [PATCH 3/6] ldbl-128ibm-compat: Add regular character, fortified " Gabriel F. T. Gomes
2019-08-09 18:31 ` [PATCH 4/6] ldbl-128ibm-compat: Add wide " Gabriel F. T. Gomes
2019-08-09 18:31 ` [PATCH 5/6] ldbl-128ibm-compat: Test double values Gabriel F. T. Gomes
2019-08-09 18:31 ` [PATCH 6/6] ldbl-128ibm-compat: Test positional arguments Gabriel F. T. Gomes
2019-09-02 14:15 ` Ping. Re: [PATCH 0/6] IEEE long double printf and friends for powerpc64le Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902110321.48d0a1b2@tereshkova \
--to=gabriel@inconstante.net.br \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).