From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D5EA01F461 for ; Mon, 2 Sep 2019 14:03:39 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=HOs9JUFpA7gsadmDHV6xWiczcF4bCNJXs7NbaS2dT6k icpLJIGDOYEVUPCgrZdlmEo2FL2eFntf1U6tKLTWlZg15tFqV7LEDN0/rmTjnDOp E4gxj5S6I/i/KxkE4858I5XrYOcRzdCQ+r5IrKwlBTCWGCF1+PKZrw/HEHjbrRx4 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=A/SE8LBPoOmRoWC4Anpvi327GvQ=; b=Pb9AVgVsAxXbY3gu6 0heF2B/tjLRgpVU++KuBjNcp1HC1DnVzttldF5S2NrJo0nrb3S33R33/+o0pNetI zHGCmQCClONAkQQajlyWhfCw8tldIzqeMoW+YUvR+ltPOwU0QVCccYSfKZO2H2gM 6XZUtpRhO/RQrasd69E9pNYWtI= Received: (qmail 871 invoked by alias); 2 Sep 2019 14:03:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 860 invoked by uid 89); 2 Sep 2019 14:03:37 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo803.mail-out.ovh.net Date: Mon, 2 Sep 2019 11:03:21 -0300 From: "Gabriel F. T. Gomes" To: Florian Weimer CC: Subject: Re: [PATCH 1/6] ldbl-128ibm-compat: Add regular character printing functions Message-ID: <20190902110321.48d0a1b2@tereshkova> In-Reply-To: <20190815153021.40983ca5@tereshkova> References: <20190809183154.32605-1-gabriel@inconstante.net.br> <20190809183154.32605-2-gabriel@inconstante.net.br> <87wofgdl5s.fsf@oldenburg2.str.redhat.com> <20190815153021.40983ca5@tereshkova> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 2392537302783282836 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudejtddgjedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm On Thu, 15 Aug 2019, Gabriel F. T. Gomes wrote: >On Wed, 14 Aug 2019, Florian Weimer wrote: > >>Why isn't the assignment to obj-suf-foreach dead? > >Oh! There's a hunk missing in this patch. It should have the following >extra statement: > >+$(call obj-suf-foreach,$(ldbl-ibm128-files)): \ >+ sysdep-CFLAGS += -mabi=ibmlongdouble > >I accidentally removed it when preparing the patch for submission. Sorry >and thanks for catching it. > >It does not affect the test results because there's nothing currently >adding -mabi=ieeelongdouble to the build of powerpc64le files. Anyway, >I'll reinstate this hunk locally, because it makes it clear *and explicit* >that these files must be built with -mabi=ibmlongdouble, regardless of >what becomes the default (if the default changes). Are you OK with this explanation (and amendment)? I like the idea of making it explicit that -mabi=ibmlongdouble is required for these files.