From: TAMUKI Shoichi <tamuki@linet.gr.jp>
To: Rafal Luzynski <digitalfreak@lingonborough.com>,
libc-alpha@sourceware.org
Cc: Felix Yan <felixonmars@archlinux.org>
Subject: Re: [PATCH 3/3] time: Add tests for Minguo calendar [BZ #24293]
Date: Wed, 20 Mar 2019 18:21:51 +0900 [thread overview]
Message-ID: <201903200921.AA04295@tamuki.linet.gr.jp> (raw)
In-Reply-To: <116203190.41216.1552952155557@poczta.nazwa.pl>
Hello Rafal-san,
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH 3/3] time: Add tests for Minguo calendar [BZ #24293]
Date: Tue, 19 Mar 2019 00:35:55 +0100 (CET)
> > Since cmn_TW.UTF8 and zh_TW.UTF-8 are practically the same, I think
> > that the test of only zh_TW.UTF-8 is sufficient.
>
> My intention was to ensure that the patch works not just for zh_TW
> but also for other locales. What is the recommended *_TW which is
> sufficiently different from zh_TW?
Sorry, you are correct. These *_TW locales are similar to each other,
but they are definitely different. Therefore, I have now reconsidered
all *_TW locales (except nan_TW@latin) should be checked.
> I admit the content of all *_TW locales is the same here. If indeed
> all these locales are so similar I don't mind to remove cmn_TW
> and leave zh_TW only.
The *_TW locales are shown below. Please take care of this order in
accordance with ISO 639-[13].
zh_TW Chinese
cmn_TW Mandarin Chinese
hak_TW Hakka Chinese
nan_TW Min Nan Chinese
lzh_TW Literary Chinese
Since the code for these *_TW locales are exactly same, so we can
unify these as follows:
| else if (i >= 3 && i <= 7) /* {zh,cmn,hak,nan,lzh}_TW */
| {
| [...]
| }
Regards,
TAMUKI Shoichi
next prev parent reply other threads:[~2019-03-20 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 11:46 [PATCH 0/3] Additional changes after introducing Minguo calendar and zero-padding in %Ey Rafal Luzynski
2019-03-15 11:47 ` [PATCH 1/3] NEWS: Mention Minguo calendar support added [BZ #24293] Rafal Luzynski
2019-03-17 10:28 ` TAMUKI Shoichi
2019-03-18 23:24 ` Rafal Luzynski
2019-03-15 11:48 ` [PATCH 2/3] time/tst-strftime2.c: Make the file easier to maintain Rafal Luzynski
2019-03-17 10:32 ` TAMUKI Shoichi
2019-03-18 23:30 ` Rafal Luzynski
2019-03-20 9:19 ` TAMUKI Shoichi
2019-03-27 3:28 ` TAMUKI Shoichi
2019-03-15 11:49 ` [PATCH 3/3] time: Add tests for Minguo calendar [BZ #24293] Rafal Luzynski
2019-03-15 11:53 ` Rafal Luzynski
2019-03-17 10:35 ` TAMUKI Shoichi
2019-03-18 23:35 ` Rafal Luzynski
2019-03-20 9:21 ` TAMUKI Shoichi [this message]
2019-03-24 11:40 ` TAMUKI Shoichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903200921.AA04295@tamuki.linet.gr.jp \
--to=tamuki@linet.gr.jp \
--cc=digitalfreak@lingonborough.com \
--cc=felixonmars@archlinux.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).