* Patch "y2038: Make CONFIG_64BIT_TIME unconditional" has been added to the 5.1-stable tree
@ 2019-05-23 18:02 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2019-05-23 18:02 UTC (permalink / raw)
To: 20190422090710.bmxdhhankurhafxq, 20190429131951.471701-1-arnd,
arnd, deepa.kernel, gregkh, joseph, libc-alpha, lukma, stepan,
tglx
Cc: stable-commits
This is a note to let you know that I've just added the patch titled
y2038: Make CONFIG_64BIT_TIME unconditional
to the 5.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
y2038-make-config_64bit_time-unconditional.patch
and it can be found in the queue-5.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From f3d964673b2f1c5d5c68c77273efcf7103eed03b Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 29 Apr 2019 15:19:37 +0200
Subject: y2038: Make CONFIG_64BIT_TIME unconditional
From: Arnd Bergmann <arnd@arndb.de>
commit f3d964673b2f1c5d5c68c77273efcf7103eed03b upstream.
As Stepan Golosunov points out, there is a small mistake in the
get_timespec64() function in the kernel. It was originally added under the
assumption that CONFIG_64BIT_TIME would get enabled on all 32-bit and
64-bit architectures, but when the conversion was done, it was only turned
on for 32-bit ones.
The effect is that the get_timespec64() function never clears the upper
half of the tv_nsec field for 32-bit tasks in compat mode. Clearing this is
required for POSIX compliant behavior of functions that pass a 'timespec'
structure with a 64-bit tv_sec and a 32-bit tv_nsec, plus uninitialized
padding.
The easiest fix for linux-5.1 is to just make the Kconfig symbol
unconditional, as it was originally intended. As a follow-up, the #ifdef
CONFIG_64BIT_TIME can be removed completely..
Note: for native 32-bit mode, no change is needed, this works as
designed and user space should never need to clear the upper 32
bits of the tv_nsec field, in or out of the kernel.
Fixes: 00bf25d693e7 ("y2038: use time32 syscall names on 32-bit")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Cc: linux-api@vger.kernel.org
Cc: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Lukasz Majewski <lukma@denx.de>
Cc: Stepan Golosunov <stepan@golosunov.pp.ru>
Link: https://lore.kernel.org/lkml/20190422090710.bmxdhhankurhafxq@sghpc.golosunov.pp.ru/
Link: https://lkml.kernel.org/r/20190429131951.471701-1-arnd@arndb.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -764,7 +764,7 @@ config COMPAT_OLD_SIGACTION
bool
config 64BIT_TIME
- def_bool ARCH_HAS_64BIT_TIME
+ def_bool y
help
This should be selected by all architectures that need to support
new system calls with a 64-bit time_t. This is relevant on all 32-bit
Patches currently in stable-queue which might be from arnd@arndb.de are
queue-5.1/y2038-make-config_64bit_time-unconditional.patch
queue-5.1/media-seco-cec-fix-building-with-rc_core-m.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-05-23 18:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 18:02 Patch "y2038: Make CONFIG_64BIT_TIME unconditional" has been added to the 5.1-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).