From: Michael Clark via Libc-alpha <libc-alpha@sourceware.org>
To: Zack Weinberg <zackw@panix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] ldd: revise trace output for left-aligned relative addresses
Date: Wed, 7 Oct 2020 13:40:28 +1300 [thread overview]
Message-ID: <02A545CC-21A5-4E9B-97BA-E8D79FF2F333@mac.com> (raw)
In-Reply-To: <CAKCAbMjBMwtczPTYZ=XtpapTrbRrjTawz==YGqpD3nkRTcH8qw@mail.gmail.com>
> On 7/10/2020, at 1:12 PM, Zack Weinberg <zackw@panix.com> wrote:
>
> On Tue, Oct 6, 2020 at 7:57 PM Michael Clark via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> This change updates ld.so trace for left-aligned relative addresses.
>> The primary goal of this change is to increase `ldd` readability by:
>>
>> - modifying trace output to use relative addresses by default.
>> - adding an alternative trace output mode with left-aligned addresses.
>
> I don't have an opinion on most of the patch, but I find the term
> "left-aligned addresses" very confusing -- in fact, on a first read I
> thought your patch did exactly the opposite of what it does. I'd
> describe the effect of LD_TRACE_ADDR_ALIGN=1 as "move load addresses
> from the end of the line to the beginning, and pad them with leading
> zeroes to a fixed width." Possibly the environment variable should be
> renamed to match.
agree in so many words
downstream parsing
could be quite disturbed
the commit message
could be very short
perhaps words yours
next prev parent reply other threads:[~2020-10-07 0:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 5:42 [PATCH] Subject: [PATCH] ldd trace left-justified relative addresses Michael Clark via Libc-alpha
2020-10-06 20:37 ` Michael Clark via Libc-alpha
2020-10-06 23:56 ` [PATCH v2] ldd: revise trace output for left-aligned " Michael Clark via Libc-alpha
2020-10-07 0:12 ` Zack Weinberg
2020-10-07 0:40 ` Michael Clark via Libc-alpha [this message]
2020-10-07 21:01 ` Adhemerval Zanella via Libc-alpha
2020-10-08 5:44 ` Michael Clark via Libc-alpha
2020-10-08 12:09 ` Adhemerval Zanella via Libc-alpha
2020-10-09 4:30 ` Michael Clark via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A545CC-21A5-4E9B-97BA-E8D79FF2F333@mac.com \
--to=libc-alpha@sourceware.org \
--cc=michaeljclark@mac.com \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).