From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3910F1F4B4 for ; Wed, 7 Oct 2020 00:40:36 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E46843857C5B; Wed, 7 Oct 2020 00:40:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E46843857C5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602031235; bh=HvAo/fDE4u8Bl8sQmUfCRa8It/FgS5kCxYO9eSyldDE=; h=Subject:Date:References:In-Reply-To:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FTI5wgz8ZYKvVBOY8YSqxAFwbSfx0cbdzZQvM/IHC+kjKSD1Coc7ui1fZPXu12mYB 7Clj9/+X5QvXFkbqa5bJLH9zuHu0+k5LB6+n6lAWkybpX9XBtRIb9QZfOdB2GlW1YW Rtfi79Y8pEazqrgL84Kyr45ece6/jdEvxyqsJYEY= Received: from mr85p00im-ztdg06021701.me.com (mr85p00im-ztdg06021701.me.com [17.58.23.196]) by sourceware.org (Postfix) with ESMTPS id 3B7493858D35 for ; Wed, 7 Oct 2020 00:40:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B7493858D35 Received: from [192.168.17.4] (125-239-162-180-vdsl.sparkbb.co.nz [125.239.162.180]) by mr85p00im-ztdg06021701.me.com (Postfix) with ESMTPSA id 1F484A00967; Wed, 7 Oct 2020 00:40:31 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2] ldd: revise trace output for left-aligned relative addresses Date: Wed, 7 Oct 2020 13:40:28 +1300 Message-Id: <02A545CC-21A5-4E9B-97BA-E8D79FF2F333@mac.com> References: In-Reply-To: To: Zack Weinberg X-Mailer: iPhone Mail (18A393) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-06_15:2020-10-06, 2020-10-06 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=969 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2010070000 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Michael Clark via Libc-alpha Reply-To: Michael Clark Cc: GNU C Library Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" > On 7/10/2020, at 1:12 PM, Zack Weinberg wrote: >=20 > =EF=BB=BFOn Tue, Oct 6, 2020 at 7:57 PM Michael Clark via Libc-alpha > wrote: >>=20 >> This change updates ld.so trace for left-aligned relative addresses. >> The primary goal of this change is to increase `ldd` readability by: >>=20 >> - modifying trace output to use relative addresses by default. >> - adding an alternative trace output mode with left-aligned addresses. >=20 > I don't have an opinion on most of the patch, but I find the term > "left-aligned addresses" very confusing -- in fact, on a first read I > thought your patch did exactly the opposite of what it does. I'd > describe the effect of LD_TRACE_ADDR_ALIGN=3D1 as "move load addresses > from the end of the line to the beginning, and pad them with leading > zeroes to a fixed width." Possibly the environment variable should be > renamed to match. agree in so many words downstream parsing could be quite disturbed the commit message could be very short perhaps words yours