git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Дилян Палаузов" <dilyan.palauzov@aegee.org>
Cc: git@vger.kernel.org, wxs@FreeBSD.org,
	Dmitry Marakasov <amdmi3@amdmi3.ru>
Subject: Re: [PATCH] configure.ac: link with -liconv for locale_charset()
Date: Thu, 20 Mar 2014 14:12:48 -0700	[thread overview]
Message-ID: <xmqqzjkkwp4f.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <531F902D.4050102@aegee.org> ("Дилян Палаузов"'s message of "Tue, 11 Mar 2014 23:37:33 +0100")

Дилян Палаузов  <dilyan.palauzov@aegee.org> writes:

> diff --git a/Makefile b/Makefile
> index dddaf4f..dce4694 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -59,9 +59,9 @@ all::
>  # FreeBSD can use either, but MinGW and some others need to use
>  # libcharset.h's locale_charset() instead.
>  #
> -# Define CHARSET_LIB to you need to link with library other than -liconv to
> +# Define CHARSET_LIB to the library you need to link with in order to
>  # use locale_charset() function.  On some platforms this needs to set to
> -# -lcharset
> +# -lcharset, on others to -liconv .
>  #
>  # Define LIBC_CONTAINS_LIBINTL if your gettext implementation doesn't
>  # need -lintl when linking.

This was unfortunately lost in the noise and I missed it.  I think
the updated text is much more clear than the original.

Thanks.

  reply	other threads:[~2014-03-20 21:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 18:35 [PATCH] configure.ac: link with -liconv for locale_charset() Dmitry Marakasov
2014-03-11 20:35 ` Junio C Hamano
2014-03-11 22:37   ` Дилян Палаузов
2014-03-20 21:12     ` Junio C Hamano [this message]
2014-03-11 22:39   ` Dmitry Marakasov
2014-03-12  0:57   ` Dmitry Marakasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzjkkwp4f.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=amdmi3@amdmi3.ru \
    --cc=dilyan.palauzov@aegee.org \
    --cc=git@vger.kernel.org \
    --cc=wxs@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).