From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Дилян Палаузов" <dilyan.palauzov@aegee.org>,
git@vger.kernel.org, wxs@FreeBSD.org
Subject: Re: [PATCH] configure.ac: link with -liconv for locale_charset()
Date: Wed, 12 Mar 2014 04:57:02 +0400 [thread overview]
Message-ID: <20140312005702.GA81282@hades.panopticon> (raw)
In-Reply-To: <xmqqsiqoo4ma.fsf@gitster.dls.corp.google.com>
* Junio C Hamano (gitster@pobox.com) wrote:
> Looks sensible; Dilyan, any comments?
Another addendum, comment from Tijl Coosemans <tijl@FreeBSD.org> who
just fixed this problem in FreeBSD ports (differently):
---
Please let upstream know they should either use iconv from libc +
nl_langinfo from libc, or iconv from libiconv + locale_charset from
libiconv, but not mix the two. Actually they could just always use
nl_langinfo when it's available because locale_charset is not much
more than an alias for it.
---
The fix used in ports was to just disable check for libcharset.h:
http://www.freebsd.org/cgi/query-pr.cgi?pr=187326#reply3
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
prev parent reply other threads:[~2014-03-12 0:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 18:35 [PATCH] configure.ac: link with -liconv for locale_charset() Dmitry Marakasov
2014-03-11 20:35 ` Junio C Hamano
2014-03-11 22:37 ` Дилян Палаузов
2014-03-20 21:12 ` Junio C Hamano
2014-03-11 22:39 ` Dmitry Marakasov
2014-03-12 0:57 ` Dmitry Marakasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312005702.GA81282@hades.panopticon \
--to=amdmi3@amdmi3.ru \
--cc=dilyan.palauzov@aegee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wxs@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).