git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <sbeller@google.com>,
	Yong Bakos <junk@humanoriented.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>,
	barkalow@iabervon.org, Yong Bakos <ybakos@humanoriented.com>
Subject: Re: [PATCH] transport, send-pack: append period to up-to-date message
Date: Wed, 25 May 2016 15:55:59 -0700	[thread overview]
Message-ID: <xmqqy46xycg0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160525224733.GF13776@sigill.intra.peff.net> (Jeff King's message of "Wed, 25 May 2016 17:47:34 -0500")

Jeff King <peff@peff.net> writes:

> I think messages to stderr are generally fair game for changing, even in
> plumbing. In many cases they are also translated (and I would argue that
> these messages probably should be translated, too).

I think I agree.  My first reaction to this thread indeed was "Why
isn't this marked for translation?"; as to the change proposed by
the patch itself, my reaction actually was "Meh" ;-)

> That being said, CodingGuidelines says:
>
>    - Do not end error messages with a full stop.

Thanks for pointing it out---I forgot about that one.

I do not think there was a concrete reason why they should not end
with a full stop, other than "be consistent with existing ones that
do not end with a full stop", though.

> This isn't an error message exactly, but I think it's in the same vein.
> I will note that we have not historically been consistent here, though
> (as evidenced by the noted message in git-merge).

  reply	other threads:[~2016-05-25 22:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 20:51 [PATCH] transport, send-pack: append period to up-to-date message Yong Bakos
2016-05-24 21:21 ` Stefan Beller
2016-05-25 22:47   ` Jeff King
2016-05-25 22:55     ` Junio C Hamano [this message]
2016-05-26 14:16       ` Yong Bakos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy46xycg0.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=junk@humanoriented.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=ybakos@humanoriented.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).