From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Yong Bakos <junk@humanoriented.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
barkalow@iabervon.org, Yong Bakos <ybakos@humanoriented.com>
Subject: Re: [PATCH] transport, send-pack: append period to up-to-date message
Date: Wed, 25 May 2016 17:47:34 -0500 [thread overview]
Message-ID: <20160525224733.GF13776@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kayB59-U52oAw=13a2CAhJLsfmoD6JbAURbt0p8g8a8fg@mail.gmail.com>
On Tue, May 24, 2016 at 02:21:00PM -0700, Stefan Beller wrote:
> On Tue, May 24, 2016 at 1:51 PM, Yong Bakos <junk@humanoriented.com> wrote:
> > Appending a period to "Everything up-to-date" makes the output message
> > consistent with similar output in builtin/merge.c.
> >
> > Signed-off-by: Yong Bakos <ybakos@humanoriented.com>
> > ---
> > builtin/send-pack.c | 2 +-
> > transport.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> > index 1ff5a67..67d9304 100644
> > --- a/builtin/send-pack.c
> > +++ b/builtin/send-pack.c
>
> While consistency is a good idea in general, I wonder how that applies here.
> git-send-pack is a low level (i.e. plumbing) command.
>
> The interface (input, output, set of options and the semantics) to
> these low-level commands are meant to be a lot more stable than
> Porcelain level commands, because these commands are primarily for
> scripted use. The interface to Porcelain commands on the other hand are
> subject to change in order to improve the end user experience.
>
> So if another porcelain exists and compares the output string
> exactly, this would be a regression for them. That is why I'd refrain
> from updating these strings
I think messages to stderr are generally fair game for changing, even in
plumbing. In many cases they are also translated (and I would argue that
these messages probably should be translated, too).
That being said, CodingGuidelines says:
- Do not end error messages with a full stop.
This isn't an error message exactly, but I think it's in the same vein.
I will note that we have not historically been consistent here, though
(as evidenced by the noted message in git-merge).
-Peff
next prev parent reply other threads:[~2016-05-25 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 20:51 [PATCH] transport, send-pack: append period to up-to-date message Yong Bakos
2016-05-24 21:21 ` Stefan Beller
2016-05-25 22:47 ` Jeff King [this message]
2016-05-25 22:55 ` Junio C Hamano
2016-05-26 14:16 ` Yong Bakos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525224733.GF13776@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=junk@humanoriented.com \
--cc=sbeller@google.com \
--cc=ybakos@humanoriented.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).