From: Junio C Hamano <gitster@pobox.com>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] completion: support excluding refs
Date: Wed, 24 Aug 2016 09:52:22 -0700 [thread overview]
Message-ID: <xmqqy43mqfcp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160824084152.2857-1-judge.packham@gmail.com> (Chris Packham's message of "Wed, 24 Aug 2016 20:41:52 +1200")
Chris Packham <judge.packham@gmail.com> writes:
> Allow completion of refs with a ^ prefix. This allows completion of
> commands like 'git log HEAD ^origin/master'.
> ...
> + [[ "$cur" == ^* ]] && pfx="^"
> for i in HEAD FETCH_HEAD ORIG_HEAD MERGE_HEAD; do
> - if [ -e "$dir/$i" ]; then echo $i; fi
> + if [ -e "$dir/$i" ]; then echo $pfx$i; fi
> done
> format="refname:short"
> refs="refs/tags refs/heads refs/remotes"
> ;;
> esac
> - git --git-dir="$dir" for-each-ref --format="%($format)" \
> + git --git-dir="$dir" for-each-ref --format="$pfx%($format)" \
> $refs
That looks like a reasonable approach to me (but I am no expert in
this area myself).
prev parent reply other threads:[~2016-08-24 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 8:41 [RFC PATCH] completion: support excluding refs Chris Packham
2016-08-24 16:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy43mqfcp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).