From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,
	RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by dcvr.yhbt.net (Postfix) with ESMTP id 610841F6C1
	for <e@80x24.org>; Wed, 24 Aug 2016 16:56:05 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932328AbcHXQz0 (ORCPT <rfc822;e@80x24.org>);
        Wed, 24 Aug 2016 12:55:26 -0400
Received: from pb-smtp1.pobox.com ([64.147.108.70]:52712 "EHLO
        sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1754618AbcHXQyJ (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 24 Aug 2016 12:54:09 -0400
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 57C5337055;
        Wed, 24 Aug 2016 12:52:25 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=UU0sMm8OPeP12NvVWEOgDU5kQd4=; b=Zxtgsn
        UCGL8n4ORD3xX7noJZ/igTr/Bnsn8t2QOIxP/rCxCBCoYSq8vHqGB5T89t+/X28J
        0HrOS1pQgyHOfplP5CfqJGAQd0TADb1Qk12IeLwlP8pMnwMRrDbjzFBgUoSXPBCp
        OxWN8itchAQf3UlZ8dhrD3v8CDUO/1su6kKzY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=l1/UppQJJCPnJApCfrtDYzq2Yxd+yRPY
        ZHQO6q3hpwmOTF9MyNwzvFuT8KGSOR33hTUcQIqv108bOSDpm9iCYA/rtGdLYwKa
        C16vgDLCz+UdVaAwHquuXtR7jWBGtOMJBD+I9aGWmI7aWih1hwAhYQYtICZfegZW
        KUgixK7sjnM=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 4E37F37054;
        Wed, 24 Aug 2016 12:52:25 -0400 (EDT)
Received: from pobox.com (unknown [104.132.0.95])
        (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))
        (No client certificate requested)
        by pb-smtp1.pobox.com (Postfix) with ESMTPSA id CC0F637053;
        Wed, 24 Aug 2016 12:52:24 -0400 (EDT)
From:   Junio C Hamano <gitster@pobox.com>
To:     Chris Packham <judge.packham@gmail.com>
Cc:     git@vger.kernel.org
Subject: Re: [RFC PATCH] completion: support excluding refs
References: <20160824084152.2857-1-judge.packham@gmail.com>
Date:   Wed, 24 Aug 2016 09:52:22 -0700
In-Reply-To: <20160824084152.2857-1-judge.packham@gmail.com> (Chris Packham's
        message of "Wed, 24 Aug 2016 20:41:52 +1200")
Message-ID: <xmqqy43mqfcp.fsf@gitster.mtv.corp.google.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 22008626-6A1B-11E6-814B-E86612518317-77302942!pb-smtp1.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Chris Packham <judge.packham@gmail.com> writes:

> Allow completion of refs with a ^ prefix. This allows completion of
> commands like 'git log HEAD ^origin/master'.
> ...
> +			[[ "$cur" == ^* ]] && pfx="^"
>  			for i in HEAD FETCH_HEAD ORIG_HEAD MERGE_HEAD; do
> -				if [ -e "$dir/$i" ]; then echo $i; fi
> +				if [ -e "$dir/$i" ]; then echo $pfx$i; fi
>  			done
>  			format="refname:short"
>  			refs="refs/tags refs/heads refs/remotes"
>  			;;
>  		esac
> -		git --git-dir="$dir" for-each-ref --format="%($format)" \
> +		git --git-dir="$dir" for-each-ref --format="$pfx%($format)" \
>  			$refs

That looks like a reasonable approach to me (but I am no expert in
this area myself).