git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, tboegi@web.de
Subject: Re: [PATCH v1 0/2] Fix default macOS build locally and on Travis CI
Date: Wed, 09 Nov 2016 15:39:46 -0800	[thread overview]
Message-ID: <xmqqwpgc6x4t.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161017002550.88782-1-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Sun, 16 Oct 2016 17:25:48 -0700")

larsxschneider@gmail.com writes:

> From: Lars Schneider <larsxschneider@gmail.com>
>
> Apple removed the OpenSSL header files in macOS and therefore Git does
> not build out of the box on macOS anymore. See previous discussion with
> Torsten here: http://public-inbox.org/git/565B3036.8000604@web.de/
>
> This mini series makes Git build out of the box on macOS, again, and
> disables the HTTPD tests on macOS TravisCI as they don't work anymore
> with the new macOS TravisCI default image:
> https://blog.travis-ci.com/2016-10-04-osx-73-default-image-live/
>
> Thanks,
> Lars
>
>
> Lars Schneider (2):
>   config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11
>   travis-ci: disable GIT_TEST_HTTPD for macOS
>
>  .travis.yml      | 3 ++-
>  config.mak.uname | 6 ++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)

I've followed what was available at the public-inbox archive, but it
is unclear what the conclusion was.  

For the first one your "how about" non-patch, to which Peff said
"that's simple and good", looked good to me as well, but is it
available as a final patch that I can just take and apply (otherwise
I think I can do the munging myself, but I'd rather be spoon-fed
when able ;-).

I do not have a strong opinion on the second one.  For an interim
solution, disabling webserver tests certainly is expedite and safe,
so I am fine taking it as-is, but I may have missed strong
objections.

Thanks.



  parent reply	other threads:[~2016-11-09 23:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17  0:25 [PATCH v1 0/2] Fix default macOS build locally and on Travis CI larsxschneider
2016-10-17  0:25 ` [PATCH v1 1/2] config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11 larsxschneider
2016-10-17  9:50   ` Jeff King
2016-11-06 19:35     ` Lars Schneider
2016-11-07 17:26       ` Jeff King
2016-11-07 17:36         ` Paul Smith
2016-11-07 17:46           ` Jeff King
2016-11-07 17:49             ` Paul Smith
2016-11-09  8:18         ` Torsten Bögershausen
2016-11-09  9:29           ` Lars Schneider
2016-11-09 10:51             ` Torsten Bögershausen
2016-11-10 11:13               ` [PATCH v2] Makefile: set NO_OPENSSL on macOS by default larsxschneider
2016-10-17  0:25 ` [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS larsxschneider
2016-11-06 21:42   ` Lars Schneider
2016-11-07 21:20     ` Jeff King
2016-11-10 11:07       ` Lars Schneider
2016-11-10 16:10         ` Jeff King
2016-11-10 21:33           ` Junio C Hamano
2016-11-10 21:43             ` Jeff King
2016-11-10 21:49               ` Junio C Hamano
2016-11-10 21:54                 ` Jeff King
2016-11-11  8:22           ` Lars Schneider
2016-11-11  8:47             ` Jeff King
2016-11-11  9:13               ` Lars Schneider
2016-11-11  9:28                 ` Jeff King
2016-11-15 12:07             ` Heiko Voigt
2016-11-15 14:18               ` Lars Schneider
2016-11-15 15:31               ` Jeff King
2016-11-16 14:39                 ` Heiko Voigt
2016-11-16 20:01                   ` Torsten Bögershausen
2016-11-09 23:39 ` Junio C Hamano [this message]
2016-11-10  6:41   ` [PATCH v1 0/2] Fix default macOS build locally and on Travis CI Torsten Bögershausen
2016-11-10 11:19   ` Lars Schneider
2016-11-10 21:34     ` Junio C Hamano
2016-11-11  9:01       ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwpgc6x4t.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).