git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Torsten Bögershausen" <tboegi@web.de>, git <git@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS
Date: Thu, 10 Nov 2016 12:07:14 +0100	[thread overview]
Message-ID: <CBAF806C-7E1E-4490-A07C-F98DB7488F5F@gmail.com> (raw)
In-Reply-To: <20161107212004.x4y7bcl2p4chfkm6@sigill.intra.peff.net>


> On 07 Nov 2016, at 22:20, Jeff King <peff@peff.net> wrote:
> 
> On Sun, Nov 06, 2016 at 10:42:36PM +0100, Lars Schneider wrote:
> 
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>> 
>>> TravisCI changed their default macOS image from 10.10 to 10.11 [1].
>>> Unfortunately the HTTPD tests do not run out of the box using the
>>> pre-installed Apache web server anymore. Therefore we enable these
>>> tests only for Linux and disable them for macOS.
>> [...]
>> Hi Junio,
>> 
>> the patch above is one of two patches to make TravisCI pass, again.
>> Could you queue it?
> 
> I don't really mind disabling tests if they don't run on a platform. But
> the more interesting question to me is: why don't they run any more? Is
> there some config tweak needed, or is it an insurmountable problem?

I can't really remember what the problem was. I think some apache config
required some module that was not present and I wasn't able to get this
working quickly.


> Using Apache in the tests has been the source of frequent portability
> problems and configuration headaches. I do wonder if we'd be better off
> using some small special-purpose web server (even a short perl script
> written around HTTP::Server::Simple or something).
> 
> On the other hand, testing against Apache approximates a more real-world
> case, which has value. It might be nice if our tests supported multiple
> web servers, but that would mean duplicating the config for each
> manually.

I agree that the real-world Apache test is more valuable and I really want
to keep the Linux Apache test running. However, I don't think many people
use macOS as Git web server and therefore I thought it is not worth the
effort to investigate this problem further.

- Lars

  reply	other threads:[~2016-11-10 11:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17  0:25 [PATCH v1 0/2] Fix default macOS build locally and on Travis CI larsxschneider
2016-10-17  0:25 ` [PATCH v1 1/2] config.mak.in: set NO_OPENSSL and APPLE_COMMON_CRYPTO for macOS >10.11 larsxschneider
2016-10-17  9:50   ` Jeff King
2016-11-06 19:35     ` Lars Schneider
2016-11-07 17:26       ` Jeff King
2016-11-07 17:36         ` Paul Smith
2016-11-07 17:46           ` Jeff King
2016-11-07 17:49             ` Paul Smith
2016-11-09  8:18         ` Torsten Bögershausen
2016-11-09  9:29           ` Lars Schneider
2016-11-09 10:51             ` Torsten Bögershausen
2016-11-10 11:13               ` [PATCH v2] Makefile: set NO_OPENSSL on macOS by default larsxschneider
2016-10-17  0:25 ` [PATCH v1 2/2] travis-ci: disable GIT_TEST_HTTPD for macOS larsxschneider
2016-11-06 21:42   ` Lars Schneider
2016-11-07 21:20     ` Jeff King
2016-11-10 11:07       ` Lars Schneider [this message]
2016-11-10 16:10         ` Jeff King
2016-11-10 21:33           ` Junio C Hamano
2016-11-10 21:43             ` Jeff King
2016-11-10 21:49               ` Junio C Hamano
2016-11-10 21:54                 ` Jeff King
2016-11-11  8:22           ` Lars Schneider
2016-11-11  8:47             ` Jeff King
2016-11-11  9:13               ` Lars Schneider
2016-11-11  9:28                 ` Jeff King
2016-11-15 12:07             ` Heiko Voigt
2016-11-15 14:18               ` Lars Schneider
2016-11-15 15:31               ` Jeff King
2016-11-16 14:39                 ` Heiko Voigt
2016-11-16 20:01                   ` Torsten Bögershausen
2016-11-09 23:39 ` [PATCH v1 0/2] Fix default macOS build locally and on Travis CI Junio C Hamano
2016-11-10  6:41   ` Torsten Bögershausen
2016-11-10 11:19   ` Lars Schneider
2016-11-10 21:34     ` Junio C Hamano
2016-11-11  9:01       ` Lars Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CBAF806C-7E1E-4490-A07C-F98DB7488F5F@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).