From: Junio C Hamano <email@example.com> To: Ben Peart <firstname.lastname@example.org> Cc: Ben Peart <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Johannes.Schindelin@gmx.de, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v1 1/4] fastindex: speed up index load through parallelization Date: Wed, 15 Nov 2017 10:12:10 +0900 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> (Ben Peart's message of "Tue, 14 Nov 2017 10:40:00 -0500") Ben Peart <email@example.com> writes: > I have no thoughts or plans for changes in the future of IEOT (which I > plan to rename ITOC). At this point in time, I can't even imagine > what else we'd want as the index only contains cache entries, ... Yeah, but the thing is that this is open source, and the imagination of the originator of the initial idea does not limit how the code and data structure evolves. Back when I added the index extensions to the system, I didn't have perfect foresight, and I didn't have specific plans to add anything beyond "TREE" to optimize "write-tree" and "diff-index --cached". In hindsight, I got one thing right and one thing wrong. Even though I didn't have any plan to add a mandatory extension, I made the code to ignore optional ones and error out on mandatory ones if an index extension section is not understood. It turns out that later (in fact much later---the "TREE" extension dates back to April 2006, while "link" came in June 2014) we could add the split-index mode without having to worry about older versions of Git doing random wrong things when they see this new extension, thanks to that design decision. That went well. On the other hand, I didn't think things through to realize that some operations may want to peek only the extensions without ever using the main table, that some other operations may want to read some extensions first before reading the main table, or more importantly, that these limitations would start mattering once Git becomes popular enough and starts housing a project tree with very many paths in the main table. I really wish somebody had brought it up as a potential issue during the review---I would have defined the extended index format to have the simple extension at the end that points back to the tail end of the main table back then, and we wouldn't be having this back and forth now. But I was just too happy and excited that I have found a room to squeeze extension sections into the index file format without breaking existing implementations of Git (which checked the trailer checksum matches to the result of hashing the whole thing, and read the recorded number of entries from the main table, without even noticing that there is a gap in between), and that excitement blinded me. > I understand the risk but the list of offsets into the cache entries > is pretty simple as well. I prefer the simplicity of a single TOC > extension that gives us random access to the entire index rather than > having to piece one together using multiple extensions. That model > has its own set of risks and tradeoffs. I thought that you are not using the "where does the series of extensions begin" information in the first place, no? That piece of information is useful independent of the usefulness of "index into the main table to list entries where the prefix-compression is reset". So if anything, I'd prefer the simplicity of introducing that "where does the series of extensions begin" that does not say anything else, and build on other things like ITOC as mere users of the mechanism.
next prev parent reply index Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-09 14:17 [PATCH v1 0/4] Speed " Ben Peart 2017-11-09 14:17 ` [PATCH v1 1/4] fastindex: speed " Ben Peart 2017-11-10 4:46 ` Junio C Hamano 2017-11-13 16:42 ` Ben Peart 2017-11-14 1:10 ` Junio C Hamano 2017-11-14 14:31 ` Ben Peart 2017-11-14 15:04 ` Junio C Hamano 2017-11-14 15:40 ` Ben Peart 2017-11-15 1:12 ` Junio C Hamano [this message] 2017-11-15 4:16 ` Ben Peart 2017-11-15 4:40 ` Junio C Hamano 2017-11-20 14:01 ` Ben Peart 2017-11-20 14:20 ` Jeff King 2017-11-20 15:38 ` Jeff King 2017-11-20 23:51 ` Ramsay Jones 2017-11-21 0:45 ` Ben Peart 2017-11-09 14:17 ` [PATCH v1 2/4] update-index: add fastindex support to update-index Ben Peart 2017-11-09 14:17 ` [PATCH v1 3/4] fastindex: add test tools and a test script Ben Peart 2017-11-09 14:17 ` [PATCH v1 4/4] fastindex: add documentation for the fastindex extension Ben Peart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Johannes.Schindelin@gmx.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
email@example.com list mirror (unofficial, one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git