From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Toon Claes" <toon@iotcl.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
git@vger.kernel.org, "Zeger-Jan van de Weg" <git@zjvandeweg.nl>
Subject: Re: [PATCH 1/1] commit: add support to provide --coauthor
Date: Fri, 11 Oct 2019 13:09:45 +0900 [thread overview]
Message-ID: <xmqqwodbj52u.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191010163755.GA12756@sigill.intra.peff.net> (Jeff King's message of "Thu, 10 Oct 2019 12:37:56 -0400")
Jeff King <peff@peff.net> writes:
> Yes, I agree that ordering and de-duplication rules are useful, too.
> Some of that can be expressed already in trailer.* config, but I don't
> know if it would be capable enough to do everything you want (though
> again, it would be really nice to _make_ it capable enough so that other
> types besides co-authored-by can make use of them).
Yup, absolutely.
As a mature system, unlike the early days, randomly adding a
"desired" feature without first considering if a generalized form
can be added is simply irresponsible to our users. Response by
Brian on the side thread also indicates that we have already spent
enough effort to the generalized trailer support and building on
top, instead of randomly adding an ad-hoc "feature", may be the
right and feasible approach.
next prev parent reply other threads:[~2019-10-11 4:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 7:49 [PATCH 1/1] commit: add support to provide --coauthor Toon Claes
2019-10-08 8:35 ` Denton Liu
2019-10-08 10:11 ` Phillip Wood
2019-10-08 12:04 ` Phillip Wood
2019-10-09 1:40 ` SZEDER Gábor
2019-10-09 2:19 ` Junio C Hamano
2019-10-09 11:20 ` brian m. carlson
2019-10-09 11:37 ` Junio C Hamano
2019-10-09 20:31 ` Jeff King
2019-10-10 8:49 ` Toon Claes
2019-10-10 16:37 ` Jeff King
2019-10-11 4:09 ` Junio C Hamano [this message]
2019-10-10 23:07 ` brian m. carlson
2019-10-10 11:49 ` Johannes Schindelin
2019-10-10 17:00 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwodbj52u.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=git@zjvandeweg.nl \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).