git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Toon Claes" <toon@iotcl.com>,
	git@vger.kernel.org, "Zeger-Jan van de Weg" <git@zjvandeweg.nl>
Subject: Re: [PATCH 1/1] commit: add support to provide --coauthor
Date: Wed, 9 Oct 2019 16:31:06 -0400	[thread overview]
Message-ID: <20191009203105.GA7007@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqr23mlkxo.fsf@gitster-ct.c.googlers.com>

On Wed, Oct 09, 2019 at 11:19:47AM +0900, Junio C Hamano wrote:

> > I wonder how we are supposed to use this trailer in the Git project,
> > in particular in combination with Signed-off-by.  Should all
> > (co)authors sign off as well?  Or will Co-authored-by imply
> > Signed-off-by?
> 
> I think we have been happy with (1) a comment at the end of the log
> message that says X worked together with Y and Z to produce this
> patch, and (2) the trailer block that has S-o-b: from X, Y and Z,
> without any need for Co-authored-by: trailer so far, and I do not
> see any reason to change it in this project.

One advantage to making a machine-readable version is that tools on the
reading side can then count contributions, etc. For instance:

  https://github.com/git/git/commit/69f272b922df153c86db520bf9b6018a9808c2a6

shows all of the co-author avatars, and you can click through to their
pages.

> If other projects wants to use such a footer, that's their choice,
> but I am fairly negative to the idea to open the gate to unbounded
> number of new options for new trailer lines.  We do not even have
> such options like --acked=<acker>, --reported=<reporter>, for the
> trailers that are actively used already (and to make sure nobody
> misunderstands, I do not think it is a good idea to add such
> individual options).

Yeah, I'd agree that we should start first with a generic trailer line.
There might be some advantage to building trailer-specific intelligence
on top of that (for instance, it would be nice for coauthor trailers to
expand names the way --author does). But that can come after, and might
not even be in the form of specific command-line options. E.g., if the
coauthor trailer could be marked in config as "this is an ident", then
we we would know to expand it. And the same could apply to acked,
reported, etc.

-Peff

  parent reply	other threads:[~2019-10-09 20:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08  7:49 [PATCH 1/1] commit: add support to provide --coauthor Toon Claes
2019-10-08  8:35 ` Denton Liu
2019-10-08 10:11 ` Phillip Wood
2019-10-08 12:04   ` Phillip Wood
2019-10-09  1:40 ` SZEDER Gábor
2019-10-09  2:19   ` Junio C Hamano
2019-10-09 11:20     ` brian m. carlson
2019-10-09 11:37       ` Junio C Hamano
2019-10-09 20:31     ` Jeff King [this message]
2019-10-10  8:49       ` Toon Claes
2019-10-10 16:37         ` Jeff King
2019-10-11  4:09           ` Junio C Hamano
2019-10-10 23:07         ` brian m. carlson
2019-10-10 11:49       ` Johannes Schindelin
2019-10-10 17:00         ` Denton Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191009203105.GA7007@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=git@zjvandeweg.nl \
    --cc=gitster@pobox.com \
    --cc=szeder.dev@gmail.com \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).