From: Junio C Hamano <gitster@pobox.com>
To: Pranit Bauva <pranit.bauva@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C
Date: Tue, 30 Aug 2016 12:33:55 -0700 [thread overview]
Message-ID: <xmqqvayi2grg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAFZEwPP-c00aNvDKoQFiCf_-tqrP3tAwwU6KAnswfMkjyoP3QQ@mail.gmail.com> (Pranit Bauva's message of "Tue, 30 Aug 2016 23:55:40 +0530")
Pranit Bauva <pranit.bauva@gmail.com> writes:
> This is a very tricky one. I have purposely not included this after a
> lot of testing. I have hand tested with the original git and with this
> branch. The reason why anyone wouldn't be able to catch this is
> because its not covered in the test suite. I am including a patch with
> this as an attachment (because I am behind a proxy right now but don't
> worry I will include this as a commit in the next series). The
> original behaviour of git does not clean the bisect state when this
> situation occurs.
"We sometimes clean and we sometimes don't and this follows the
original" may be a valid justification but it is not a very useful
explanation. The real issue is if not cleaning is intended (and if
so why; otherwise, if it is clear that it is simply forgotten, we
can just fix it in the series as a follow-up step).
If not cleaning in some cases (but not others) is the right thing,
at least there needs an in-code comment to warn others against
"fixing" the lack of cleanups (e.g. "don't clean state here, because
the caller still wants to see what state we were for this and that
reason").
>>> + if (bisect_next_check(terms, terms->term_good.buf))
>>> + return -1;
>>
>> Mental note. The "autostart" in the original is gone. Perhaps it
>> is done by next_check in this code, but we haven't seen that yet.
>
> This will be added back again in a coming patch[1].
In other words, this series is broken at this step and the breakage
stay with the codebase until a later step?
I do not know if reordering the patches in the series is enough to
fix that, or if it is even worth to avoid such a temporary breakage.
It depends on how serious the circularity is, but I would understand
if it is too hard and not worth the effort (I think in a very early
review round some people advised against the bottom-up rewrite
because they anticipated this exact reason). At least the omission
(and later resurrection) needs to be mentioned in the log so that
people understand what is going on when they later need to bisect.
Thanks.
next prev parent reply other threads:[~2016-08-30 19:34 UTC|newest]
Thread overview: 320+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 22:35 [PATCH 0/9] Resend of gitster/pb/bisect Pranit Bauva
2016-07-12 22:35 ` [PATCH 1/9] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva
2016-07-12 22:35 ` [PATCH 2/9] bisect: rewrite `check_term_format` shell function in C Pranit Bauva
2016-07-12 22:35 ` [PATCH 3/9] bisect--helper: `write_terms` " Pranit Bauva
2016-07-12 22:35 ` [PATCH 4/9] bisect--helper: `bisect_clean_state` " Pranit Bauva
2016-07-12 22:35 ` [PATCH 5/9] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-07-12 22:35 ` [PATCH 6/9] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-07-12 22:35 ` [PATCH 7/9] bisect--helper: `bisect_reset` shell function in C Pranit Bauva
2016-07-12 22:35 ` [PATCH 8/9] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2016-07-12 22:35 ` [PATCH 9/9] bisect--helper: `bisect_write` " Pranit Bauva
2016-07-13 7:47 ` [PATCH 0/9] Resend of gitster/pb/bisect Christian Couder
2016-07-20 16:00 ` Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 01/12] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 11/12] bisect--helper: `bisect_next_check` shell function in C Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 08/12] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 09/12] bisect--helper: `bisect_write` " Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 02/12] bisect: rewrite `check_term_format` " Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 10/12] bisect--helper: `check_and_set_terms` " Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 07/12] bisect--helper: `bisect_reset` " Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva
2016-07-22 2:29 ` Torsten Bögershausen
2016-07-22 14:07 ` Pranit Bauva
2016-07-25 16:53 ` Junio C Hamano
2016-07-25 21:28 ` Christian Couder
2016-07-26 1:42 ` Torsten Bögershausen
2016-07-26 17:32 ` Junio C Hamano
2016-07-27 4:20 ` Pranit Bauva
2016-07-27 16:13 ` Junio C Hamano
2016-07-20 21:47 ` [PATCH v10 05/12] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 03/12] bisect--helper: `write_terms` shell function in C Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 04/12] bisect--helper: `bisect_clean_state` " Pranit Bauva
2016-07-20 21:47 ` [PATCH v10 06/12] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 05/13] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` shell function in C Pranit Bauva
2016-08-02 20:25 ` Junio C Hamano
2016-08-02 22:17 ` Junio C Hamano
2016-08-03 20:52 ` Pranit Bauva
2016-08-03 20:51 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` " Pranit Bauva
2016-08-02 17:31 ` Junio C Hamano
2016-08-03 20:20 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 10/13] bisect--helper: `check_and_set_terms` " Pranit Bauva
2016-08-02 18:53 ` Junio C Hamano
2016-08-03 20:29 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 07/13] bisect--helper: `bisect_reset` " Pranit Bauva
2016-08-02 18:44 ` Junio C Hamano
2016-07-31 9:21 ` [RFC/PATCH v11 03/13] bisect--helper: `write_terms` " Pranit Bauva
2016-08-02 17:38 ` Junio C Hamano
2016-08-03 20:21 ` Pranit Bauva
2016-08-04 15:39 ` Junio C Hamano
2016-07-31 9:21 ` [RFC/PATCH v11 12/13] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva
2016-08-02 19:22 ` Junio C Hamano
2016-08-03 20:33 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 13/13] bisect--helper: `bisect_start` shell function partially " Pranit Bauva
2016-08-02 20:19 ` Junio C Hamano
2016-08-03 20:49 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function " Pranit Bauva
2016-08-02 19:17 ` Junio C Hamano
2016-08-03 20:33 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` " Pranit Bauva
2016-08-02 17:46 ` Junio C Hamano
2016-08-03 20:27 ` Pranit Bauva
2016-08-04 15:45 ` Junio C Hamano
2016-08-04 16:07 ` Pranit Bauva
2016-08-04 16:50 ` Junio C Hamano
2016-08-04 16:57 ` Pranit Bauva
2016-07-31 9:21 ` [RFC/PATCH v11 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2016-08-02 18:46 ` Junio C Hamano
2016-08-02 17:25 ` [RFC/PATCH v11 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Junio C Hamano
2016-08-10 21:57 ` [PATCH v12 " Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 07/13] bisect--helper: `bisect_reset` shell function in C Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 04/13] bisect--helper: `bisect_clean_state` " Pranit Bauva
2016-08-12 19:24 ` Junio C Hamano
2016-08-10 21:57 ` [PATCH v12 10/13] bisect--helper: `check_and_set_terms` " Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 05/13] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially " Pranit Bauva
2016-08-12 19:25 ` Junio C Hamano
2016-08-13 6:33 ` Pranit Bauva
2016-08-13 7:34 ` Christian Couder
2016-08-13 13:50 ` Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 09/13] bisect--helper: `bisect_write` shell function " Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 11/13] bisect--helper: `bisect_next_check` & bisect_voc " Pranit Bauva
2016-08-12 18:11 ` Junio C Hamano
2016-08-12 18:49 ` Junio C Hamano
2016-08-13 6:32 ` Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 02/13] bisect: rewrite `check_term_format` " Pranit Bauva
2016-08-10 21:57 ` [PATCH v12 03/13] bisect--helper: `write_terms` " Pranit Bauva
2016-08-10 22:19 ` [PATCH v12 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 10/13] bisect--helper: `check_and_set_terms` shell function in C Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 11/13] bisect--helper: `bisect_next_check` & bisect_voc " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 03/13] bisect--helper: `write_terms` " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 05/13] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 07/13] bisect--helper: `bisect_reset` shell function in C Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 04/13] bisect--helper: `bisect_clean_state` shell function in C Pranit Bauva
2016-08-21 11:18 ` Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 09/13] bisect--helper: `bisect_write` " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 02/13] bisect: rewrite `check_term_format` " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 12/13] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva
2016-08-19 20:32 ` [PATCH v13 13/13] bisect--helper: `bisect_start` shell function partially " Pranit Bauva
2016-08-21 11:14 ` [PATCH v13 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 01/27] " Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 22/27] bisect--helper: `bisect_replay` shell function in C Pranit Bauva
2016-08-26 23:24 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` " Pranit Bauva
2016-08-25 20:30 ` Junio C Hamano
2016-08-30 18:25 ` Pranit Bauva
2016-08-30 18:44 ` Pranit Bauva
2016-08-30 19:33 ` Junio C Hamano [this message]
2016-08-30 20:17 ` Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 27/27] bisect--helper: remove the dequote in bisect_start() Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 02/27] bisect: rewrite `check_term_format` shell function in C Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 11/27] bisect--helper: `bisect_next_check` & bisect_voc " Pranit Bauva
2016-08-24 22:40 ` Junio C Hamano
2016-08-27 9:35 ` Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 21/27] bisect--helper: `bisect_log` " Pranit Bauva
2016-08-26 23:07 ` Junio C Hamano
2016-08-27 20:16 ` Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2016-08-24 22:13 ` Junio C Hamano
2016-08-27 9:14 ` Pranit Bauva
2016-08-29 17:17 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 26/27] bisect--helper: retire `--bisect-auto-next` subcommand Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 07/27] bisect--helper: `bisect_reset` shell function in C Pranit Bauva
2016-08-24 21:12 ` Junio C Hamano
2016-08-26 13:46 ` Pranit Bauva
2016-08-26 16:29 ` Junio C Hamano
2016-08-27 10:52 ` Pranit Bauva
2016-08-29 17:06 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 17/27] bisect--helper: `bisect_autostart` " Pranit Bauva
2016-08-26 21:09 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 24/27] bisect--helper: retire `--check-and-set-terms` subcommand Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 19/27] bisect--helper: retire `--check-expected-revs` subcommand Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 23/27] bisect--helper: retire `--bisect-write` subcommand Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 25/27] bisect--helper: retire `--bisect-autostart` subcommand Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 06/27] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 09/27] bisect--helper: `bisect_write` shell function in C Pranit Bauva
2016-08-24 22:30 ` Junio C Hamano
2016-08-27 9:33 ` Pranit Bauva
2016-08-27 21:22 ` Junio C Hamano
2016-08-30 6:42 ` Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 12/27] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva
2016-08-25 18:05 ` Junio C Hamano
2016-08-27 9:48 ` Pranit Bauva
2016-08-29 17:15 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 03/27] bisect--helper: `write_terms` " Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 10/27] bisect--helper: `check_and_set_terms` " Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 20/27] bisect--helper: retire `--write-terms` subcommand Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 18/27] bisect--helper: `bisect_state` & `bisect_head` shell function in C Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 04/27] bisect--helper: `bisect_clean_state` " Pranit Bauva
2016-08-24 20:58 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 13/27] bisect--helper: `bisect_start` shell function partially " Pranit Bauva
2016-08-25 19:02 ` Junio C Hamano
2016-08-25 19:43 ` Junio C Hamano
2016-08-27 19:47 ` Pranit Bauva
2016-08-27 20:53 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 15/27] bisect--helper: retire `--bisect-clean-state` subcommand Pranit Bauva
2016-08-26 20:56 ` Junio C Hamano
2016-08-23 11:53 ` [PATCH v14 05/27] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-08-23 11:53 ` [PATCH v14 16/27] bisect--helper: retire `--next-all` subcommand Pranit Bauva
2016-08-23 20:28 ` [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Junio C Hamano
2016-08-23 21:07 ` Pranit Bauva
2016-08-23 21:24 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 " Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 02/27] bisect: rewrite `check_term_format` shell function in C Pranit Bauva
2016-11-14 22:20 ` Stephan Beyer
2016-11-15 5:16 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 05/27] t6030: explicitly test for bisection cleanup Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 03/27] bisect--helper: `write_terms` shell function in C Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 19/27] bisect--helper: `bisect_state` & `bisect_head` " Pranit Bauva
2016-11-22 0:12 ` Stephan Beyer
2016-12-06 22:40 ` Pranit Bauva
2016-12-06 23:54 ` Stephan Beyer
2016-12-08 6:43 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 17/27] bisect--helper: retire `--next-all` subcommand Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 06/27] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 10/27] bisect--helper: `check_and_set_terms` shell function in C Pranit Bauva
2016-11-17 20:25 ` Stephan Beyer
2016-12-06 22:43 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 13/27] bisect--helper: `bisect_start` shell function partially " Pranit Bauva
2016-11-15 23:19 ` Stephan Beyer
2016-11-16 17:09 ` Pranit Bauva
2016-11-20 20:01 ` Stephan Beyer
2016-11-20 20:19 ` Stephan Beyer
2016-10-14 14:14 ` [PATCH v15 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function " Pranit Bauva
2016-11-16 23:47 ` Stephan Beyer
2016-12-06 19:33 ` Pranit Bauva
2016-12-16 19:00 ` Pranit Bauva
2016-12-17 19:42 ` Stephan Beyer
2016-12-16 19:35 ` Pranit Bauva
2016-12-17 19:55 ` Stephan Beyer
2016-10-14 14:14 ` [PATCH v15 16/27] bisect--helper: retire `--bisect-clean-state` subcommand Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 18/27] bisect--helper: `bisect_autostart` shell function in C Pranit Bauva
2016-11-20 20:15 ` Stephan Beyer
2016-12-06 19:47 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 09/27] bisect--helper: `bisect_write` " Pranit Bauva
2016-11-17 9:40 ` Stephan Beyer
2016-12-06 21:32 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 11/27] bisect--helper: `bisect_next_check` & bisect_voc " Pranit Bauva
2016-11-17 20:59 ` Stephan Beyer
2016-12-06 18:39 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 07/27] bisect--helper: `bisect_reset` " Pranit Bauva
2016-11-16 23:23 ` Stephan Beyer
2016-11-17 3:56 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 20/27] bisect--helper: retire `--check-expected-revs` subcommand Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 27/27] bisect--helper: remove the dequote in bisect_start() Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 22/27] bisect--helper: `bisect_log` shell function in C Pranit Bauva
2016-11-17 21:47 ` Stephan Beyer
2016-12-06 22:42 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 15/27] bisect--helper: `bisect_next` and `bisect_auto_next` " Pranit Bauva
2016-11-20 20:01 ` Stephan Beyer
2016-12-31 10:23 ` Pranit Bauva
2016-11-21 21:35 ` Stephan Beyer
2016-12-31 10:43 ` Pranit Bauva
2017-01-01 16:27 ` Stephan Beyer
2017-01-01 17:41 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 21/27] bisect--helper: retire `--write-terms` subcommand Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 25/27] bisect--helper: retire `--bisect-autostart` subcommand Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 26/27] bisect--helper: retire `--bisect-auto-next` subcommand Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 23/27] bisect--helper: `bisect_replay` shell function in C Pranit Bauva
2016-11-22 0:49 ` Stephan Beyer
2016-12-06 23:02 ` Pranit Bauva
2016-12-06 23:20 ` Stephan Beyer
2016-12-06 23:40 ` Stephan Beyer
2016-12-07 13:15 ` Christian Couder
2016-10-14 14:14 ` [PATCH v15 14/27] t6030: no cleanup with bad merge base Pranit Bauva
2016-10-14 21:43 ` Junio C Hamano
2016-10-15 8:46 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 12/27] bisect--helper: `get_terms` & `bisect_terms` shell function in C Pranit Bauva
2016-11-17 21:32 ` Stephan Beyer
2016-12-06 21:14 ` Pranit Bauva
2016-12-06 23:05 ` Stephan Beyer
2016-12-07 12:06 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 04/27] bisect--helper: `bisect_clean_state` " Pranit Bauva
2016-11-15 21:09 ` Stephan Beyer
2016-11-15 21:40 ` Junio C Hamano
2016-11-15 21:53 ` Stephan Beyer
2016-11-16 16:49 ` Pranit Bauva
2016-10-14 14:14 ` [PATCH v15 24/27] bisect--helper: retire `--bisect-write` subcommand Pranit Bauva
2016-10-14 15:12 ` [PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva
2017-09-29 6:49 ` [PATCH v16 1/6] " Pranit Bauva
2017-09-29 6:49 ` [PATCH v16 2/6] bisect--helper: rewrite `check_term_format` shell function in C Pranit Bauva
2017-09-29 6:49 ` [PATCH v16 5/6] t6030: explicitly test for bisection cleanup Pranit Bauva
2017-09-29 6:49 ` [PATCH v16 4/6] bisect--helper: `bisect_clean_state` shell function in C Pranit Bauva
2017-09-29 6:49 ` [PATCH v16 3/6] bisect--helper: `write_terms` " Pranit Bauva
2017-09-29 6:49 ` [PATCH v16 6/6] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva
2017-11-19 20:34 ` Christian Couder
2017-11-20 3:05 ` Junio C Hamano
2017-11-20 7:03 ` Christian Couder
2017-09-29 18:54 ` [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Stephan Beyer
2017-09-29 21:10 ` Pranit Bauva
2017-09-30 12:59 ` Ramsay Jones
2017-10-02 13:44 ` Pranit Bauva
2017-10-03 0:48 ` Ramsay Jones
2017-10-03 3:51 ` Junio C Hamano
2017-10-03 4:35 ` Pranit Bauva
2017-10-04 2:22 ` Ramsay Jones
2017-10-04 4:07 ` Junio C Hamano
2017-10-27 15:06 ` [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C Pranit Bauva
2017-10-27 15:06 ` [PATCH v16 Part II 7/8] bisect--helper: `bisect_start` shell function partially " Pranit Bauva
2017-10-30 16:51 ` Stephan Beyer
2017-10-30 17:28 ` Pranit Bauva
2018-02-16 1:22 ` SZEDER Gábor
2017-10-27 15:06 ` [PATCH v16 Part II 4/8] bisect--helper: `check_and_set_terms` shell function " Pranit Bauva
2017-11-08 0:37 ` Ramsay Jones
2017-10-27 15:06 ` [PATCH v16 Part II 3/8] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva
2017-10-27 15:06 ` [PATCH v16 Part II 2/8] bisect--helper: `bisect_write` shell function in C Pranit Bauva
2017-10-27 17:28 ` Martin Ågren
2017-10-30 17:35 ` Pranit Bauva
2018-11-23 10:13 ` Johannes Schindelin
2018-11-23 12:22 ` Martin Ågren
2018-11-26 18:18 ` Johannes Schindelin
2017-10-27 18:19 ` Junio C Hamano
2017-10-30 17:38 ` Pranit Bauva
2017-10-30 13:38 ` Stephan Beyer
2017-10-30 16:24 ` Stephan Beyer
2017-11-08 0:26 ` Ramsay Jones
2017-10-27 15:06 ` [PATCH v16 Part II 8/8] t6030: make various test to pass GETTEXT_POISON tests Pranit Bauva
2017-10-27 15:06 ` [PATCH v16 Part II 5/8] bisect--helper: `bisect_next_check` shell function in C Pranit Bauva
2017-10-27 17:35 ` Martin Ågren
2017-10-30 17:40 ` Pranit Bauva
2017-11-08 0:48 ` Ramsay Jones
2017-11-12 19:19 ` Stephan Beyer
2017-11-12 19:27 ` Stephan Beyer
2017-11-12 20:03 ` Stephan Beyer
2017-11-13 3:56 ` Junio C Hamano
2017-10-27 15:06 ` [PATCH v16 Part II 6/8] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva
2017-10-27 20:04 ` Martin Ågren
2017-10-30 17:45 ` Pranit Bauva
2017-10-30 16:34 ` Stephan Beyer
2017-10-30 17:31 ` Pranit Bauva
2017-11-08 0:59 ` Ramsay Jones
2017-10-27 15:32 ` [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` " Pranit Bauva
2017-10-27 17:40 ` Junio C Hamano
2017-10-30 17:26 ` Pranit Bauva
2017-10-30 13:22 ` Stephan Beyer
2017-10-30 17:27 ` Pranit Bauva
2017-11-08 0:07 ` Ramsay Jones
2019-01-02 15:38 ` [PATCH v17 0/7] git bisect: convert from shell to C Tanushree Tumane via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 1/7] bisect--helper: `bisect_reset` shell function in C Pranit Bauva via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 3/7] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 2/7] bisect--helper: `bisect_write` shell function in C Pranit Bauva via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 4/7] bisect--helper: `check_and_set_terms` " Pranit Bauva via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 5/7] bisect--helper: `bisect_next_check` " Pranit Bauva via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 6/7] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva via GitGitGadget
2019-01-02 15:38 ` [PATCH v17 7/7] bisect--helper: `bisect_start` shell function partially " Pranit Bauva via GitGitGadget
2019-01-03 1:19 ` [PATCH v17 0/7] git bisect: convert from shell to C Ramsay Jones
2019-01-07 9:15 ` TANUSHREE TUMANE
2016-10-27 16:59 ` [PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Junio C Hamano
2016-10-27 20:14 ` Christian Couder
2016-10-28 6:02 ` Matthieu Moy
2016-11-15 21:40 ` Stephan Beyer
2016-11-16 0:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvayi2grg.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).