From: Pranit Bauva <pranit.bauva@gmail.com> To: git@vger.kernel.org Subject: [PATCH v13 11/13] bisect--helper: `bisect_next_check` & bisect_voc shell function in C Date: Fri, 19 Aug 2016 20:32:30 +0000 [thread overview] Message-ID: <01020156a48145c7-823bdd3d-88da-4e87-9170-9d95b48607dd-000000@eu-west-1.amazonses.com> (raw) In-Reply-To: <01020156a48144f8-c0e127c1-8cd9-4295-ac16-449a54315cac-000000@eu-west-1.amazonses.com> Reimplement `bisect_next_check` shell function in C and add `bisect-next-check` subcommand to `git bisect--helper` to call it from git-bisect.sh . Also reimplement `bisect_voc` shell function in C and call it from `bisect_next_check` implementation in C. Using `--bisect-next-check` is a temporary measure to port shell function to C so as to use the existing test suite. As more functions are ported, this subcommand will be retired but its implementation will be called by some other methods. Mentored-by: Lars Schneider <larsxschneider@gmail.com> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> --- builtin/bisect--helper.c | 103 ++++++++++++++++++++++++++++++++++++++++++++++- git-bisect.sh | 60 ++------------------------- 2 files changed, 106 insertions(+), 57 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 450426c..ada3220d 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -6,6 +6,7 @@ #include "dir.h" #include "argv-array.h" #include "run-command.h" +#include "prompt.h" static GIT_PATH_FUNC(git_path_bisect_terms, "BISECT_TERMS") static GIT_PATH_FUNC(git_path_bisect_expected_rev, "BISECT_EXPECTED_REV") @@ -21,6 +22,7 @@ static const char * const git_bisect_helper_usage[] = { N_("git bisect--helper --bisect-reset [<commit>]"), N_("git bisect--helper --bisect-write <state> <revision> <TERM_GOOD> <TERM_BAD> [<nolog>]"), N_("git bisect--helper --bisect-check-and-set-terms <command> <TERM_GOOD> <TERM_BAD>"), + N_("git bisect--helper --bisect-next-check [<term>] <TERM_GOOD> <TERM_BAD"), NULL }; @@ -253,6 +255,95 @@ static int check_and_set_terms(struct bisect_terms *terms, const char *cmd) return 0; } +static int mark_good(const char *refname, const struct object_id *oid, + int flag, void *cb_data) +{ + int *m_good = (int *)cb_data; + *m_good = 0; + return 1; +} + +static char *bisect_voc(char *revision_type) +{ + if (!strcmp(revision_type, "bad")) + return "bad|new"; + if (!strcmp(revision_type, "good")) + return "good|old"; + + return NULL; +} + +static int bisect_next_check(const struct bisect_terms *terms, + const char *current_term) +{ + int missing_good = 1, missing_bad = 1; + char *bad_ref = xstrfmt("refs/bisect/%s", terms->term_bad.buf); + char *good_glob = xstrfmt("%s-*", terms->term_good.buf); + char *bad_syn, *good_syn; + + if (ref_exists(bad_ref)) + missing_bad = 0; + free(bad_ref); + + for_each_glob_ref_in(mark_good, good_glob, "refs/bisect/", + (void *) &missing_good); + free(good_glob); + + if (!missing_good && !missing_bad) + return 0; + + if (!current_term) + return -1; + + if (missing_good && !missing_bad && current_term && + !strcmp(current_term, terms->term_good.buf)) { + char *yesno; + /* + * have bad (or new) but not good (or old). We could bisect + * although this is less optimum. + */ + fprintf(stderr, N_("Warning: bisecting only with a %s commit\n"), + terms->term_bad.buf); + if (!isatty(0)) + return 0; + /* + * TRANSLATORS: Make sure to include [Y] and [n] in your + * translation. The program will only accept English input + * at this point. + */ + yesno = git_prompt(_("Are you sure [Y/n]? "), PROMPT_ECHO); + if (starts_with(yesno, "N") || starts_with(yesno, "n")) + return -1; + + return 0; + } + bad_syn = xstrdup(bisect_voc("bad")); + good_syn = xstrdup(bisect_voc("good")); + if (!is_empty_or_missing_file(git_path_bisect_start())) { + error(_("You need to give me at least one %s and " + "%s revision. You can use \"git bisect %s\" " + "and \"git bisect %s\" for that. \n"), + bad_syn, good_syn, bad_syn, good_syn); + free(bad_syn); + free(good_syn); + return -1; + } + else { + error(_("You need to start by \"git bisect start\". You " + "then need to give me at least one %s and %s " + "revision. You can use \"git bisect %s\" and " + "\"git bisect %s\" for that.\n"), + good_syn, bad_syn, bad_syn, good_syn); + free(bad_syn); + free(good_syn); + return -1; + } + free(bad_syn); + free(good_syn); + + return 0; +} + int cmd_bisect__helper(int argc, const char **argv, const char *prefix) { enum { @@ -262,7 +353,8 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) BISECT_RESET, CHECK_EXPECTED_REVS, BISECT_WRITE, - CHECK_AND_SET_TERMS + CHECK_AND_SET_TERMS, + BISECT_NEXT_CHECK } cmdmode = 0; int no_checkout = 0, res = 0; struct option options[] = { @@ -280,6 +372,8 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) N_("write out the bisection state in BISECT_LOG"), BISECT_WRITE), OPT_CMDMODE(0, "check-and-set-terms", &cmdmode, N_("check and set terms in a bisection state"), CHECK_AND_SET_TERMS), + OPT_CMDMODE(0, "bisect-next-check", &cmdmode, + N_("check whether bad or good terms exist"), BISECT_NEXT_CHECK), OPT_BOOL(0, "no-checkout", &no_checkout, N_("update BISECT_HEAD instead of checking out the current commit")), OPT_END() @@ -330,6 +424,13 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) strbuf_addstr(&terms.term_bad, argv[2]); res = check_and_set_terms(&terms, argv[0]); break; + case BISECT_NEXT_CHECK: + if (argc != 2 && argc != 3) + die(_("--bisect-next-check requires 2 or 3 arguments")); + strbuf_addstr(&terms.term_good, argv[0]); + strbuf_addstr(&terms.term_bad, argv[1]); + res = bisect_next_check(&terms, argc == 3 ? argv[2] : NULL); + break; default: die("BUG: unknown subcommand '%d'", cmdmode); } diff --git a/git-bisect.sh b/git-bisect.sh index bdf2227..fe6c9d0 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -271,59 +271,14 @@ bisect_state() { bisect_auto_next } -bisect_next_check() { - missing_good= missing_bad= - git show-ref -q --verify refs/bisect/$TERM_BAD || missing_bad=t - test -n "$(git for-each-ref "refs/bisect/$TERM_GOOD-*")" || missing_good=t - - case "$missing_good,$missing_bad,$1" in - ,,*) - : have both $TERM_GOOD and $TERM_BAD - ok - ;; - *,) - # do not have both but not asked to fail - just report. - false - ;; - t,,"$TERM_GOOD") - # have bad (or new) but not good (or old). we could bisect although - # this is less optimum. - eval_gettextln "Warning: bisecting only with a \$TERM_BAD commit." >&2 - if test -t 0 - then - # TRANSLATORS: Make sure to include [Y] and [n] in your - # translation. The program will only accept English input - # at this point. - gettext "Are you sure [Y/n]? " >&2 - read yesno - case "$yesno" in [Nn]*) exit 1 ;; esac - fi - : bisect without $TERM_GOOD... - ;; - *) - bad_syn=$(bisect_voc bad) - good_syn=$(bisect_voc good) - if test -s "$GIT_DIR/BISECT_START" - then - - eval_gettextln "You need to give me at least one \$bad_syn and one \$good_syn revision. -(You can use \"git bisect \$bad_syn\" and \"git bisect \$good_syn\" for that.)" >&2 - else - eval_gettextln "You need to start by \"git bisect start\". -You then need to give me at least one \$good_syn and one \$bad_syn revision. -(You can use \"git bisect \$bad_syn\" and \"git bisect \$good_syn\" for that.)" >&2 - fi - exit 1 ;; - esac -} - bisect_auto_next() { - bisect_next_check && bisect_next || : + git bisect--helper --bisect-next-check $TERM_GOOD $TERM_BAD && bisect_next || : } bisect_next() { case "$#" in 0) ;; *) usage ;; esac bisect_autostart - bisect_next_check $TERM_GOOD + git bisect--helper --bisect-next-check $TERM_GOOD $TERM_BAD $TERM_GOOD|| exit # Perform all bisection computation, display and checkout git bisect--helper --next-all $(test -f "$GIT_DIR/BISECT_HEAD" && echo --no-checkout) @@ -355,7 +310,7 @@ bisect_next() { } bisect_visualize() { - bisect_next_check fail + git bisect--helper --bisect-next-check $TERM_GOOD $TERM_BAD fail || exit if test $# = 0 then @@ -409,7 +364,7 @@ bisect_replay () { } bisect_run () { - bisect_next_check fail + git bisect--helper --bisect-next-check $TERM_GOOD $TERM_BAD fail || exit while true do @@ -482,13 +437,6 @@ get_terms () { fi } -bisect_voc () { - case "$1" in - bad) echo "bad|new" ;; - good) echo "good|old" ;; - esac -} - bisect_terms () { get_terms if ! test -s "$GIT_DIR/BISECT_TERMS" -- https://github.com/git/git/pull/281
next prev parent reply other threads:[~2016-08-19 20:53 UTC|newest] Thread overview: 320+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-12 22:35 [PATCH 0/9] Resend of gitster/pb/bisect Pranit Bauva 2016-07-12 22:35 ` [PATCH 1/9] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-07-12 22:35 ` [PATCH 2/9] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-07-12 22:35 ` [PATCH 3/9] bisect--helper: `write_terms` " Pranit Bauva 2016-07-12 22:35 ` [PATCH 4/9] bisect--helper: `bisect_clean_state` " Pranit Bauva 2016-07-12 22:35 ` [PATCH 5/9] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-07-12 22:35 ` [PATCH 6/9] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-07-12 22:35 ` [PATCH 7/9] bisect--helper: `bisect_reset` shell function in C Pranit Bauva 2016-07-12 22:35 ` [PATCH 8/9] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva 2016-07-12 22:35 ` [PATCH 9/9] bisect--helper: `bisect_write` " Pranit Bauva 2016-07-13 7:47 ` [PATCH 0/9] Resend of gitster/pb/bisect Christian Couder 2016-07-20 16:00 ` Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 01/12] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 04/12] bisect--helper: `bisect_clean_state` shell function in C Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 10/12] bisect--helper: `check_and_set_terms` " Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 09/12] bisect--helper: `bisect_write` " Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 11/12] bisect--helper: `bisect_next_check` " Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 03/12] bisect--helper: `write_terms` " Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 07/12] bisect--helper: `bisect_reset` " Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 02/12] bisect: rewrite `check_term_format` " Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 06/12] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 05/12] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 08/12] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C Pranit Bauva 2016-07-20 21:47 ` [PATCH v10 12/12] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva 2016-07-22 2:29 ` Torsten Bögershausen 2016-07-22 14:07 ` Pranit Bauva 2016-07-25 16:53 ` Junio C Hamano 2016-07-25 21:28 ` Christian Couder 2016-07-26 1:42 ` Torsten Bögershausen 2016-07-26 17:32 ` Junio C Hamano 2016-07-27 4:20 ` Pranit Bauva 2016-07-27 16:13 ` Junio C Hamano 2016-07-31 9:21 ` [RFC/PATCH v11 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function in C Pranit Bauva 2016-08-02 19:17 ` Junio C Hamano 2016-08-03 20:33 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 05/13] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C Pranit Bauva 2016-08-02 18:46 ` Junio C Hamano 2016-07-31 9:21 ` [RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` " Pranit Bauva 2016-08-02 17:31 ` Junio C Hamano 2016-08-03 20:20 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 09/13] bisect--helper: `bisect_write` " Pranit Bauva 2016-08-02 20:25 ` Junio C Hamano 2016-08-02 22:17 ` Junio C Hamano 2016-08-03 20:52 ` Pranit Bauva 2016-08-03 20:51 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 04/13] bisect--helper: `bisect_clean_state` " Pranit Bauva 2016-08-02 17:46 ` Junio C Hamano 2016-08-03 20:27 ` Pranit Bauva 2016-08-04 15:45 ` Junio C Hamano 2016-08-04 16:07 ` Pranit Bauva 2016-08-04 16:50 ` Junio C Hamano 2016-08-04 16:57 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 10/13] bisect--helper: `check_and_set_terms` " Pranit Bauva 2016-08-02 18:53 ` Junio C Hamano 2016-08-03 20:29 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 03/13] bisect--helper: `write_terms` " Pranit Bauva 2016-08-02 17:38 ` Junio C Hamano 2016-08-03 20:21 ` Pranit Bauva 2016-08-04 15:39 ` Junio C Hamano 2016-07-31 9:21 ` [RFC/PATCH v11 12/13] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva 2016-08-02 19:22 ` Junio C Hamano 2016-08-03 20:33 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 13/13] bisect--helper: `bisect_start` shell function partially " Pranit Bauva 2016-08-02 20:19 ` Junio C Hamano 2016-08-03 20:49 ` Pranit Bauva 2016-07-31 9:21 ` [RFC/PATCH v11 07/13] bisect--helper: `bisect_reset` shell function " Pranit Bauva 2016-08-02 18:44 ` Junio C Hamano 2016-07-31 9:21 ` [RFC/PATCH v11 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-08-02 17:25 ` [RFC/PATCH v11 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Junio C Hamano 2016-08-10 21:57 ` [PATCH v12 " Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 12/13] bisect--helper: `get_terms` & `bisect_terms` shell function in C Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 07/13] bisect--helper: `bisect_reset` " Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 03/13] bisect--helper: `write_terms` " Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 05/13] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 09/13] bisect--helper: `bisect_write` shell function in C Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 11/13] bisect--helper: `bisect_next_check` & bisect_voc " Pranit Bauva 2016-08-12 18:11 ` Junio C Hamano 2016-08-12 18:49 ` Junio C Hamano 2016-08-13 6:32 ` Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 02/13] bisect: rewrite `check_term_format` " Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 13/13] bisect--helper: `bisect_start` shell function partially " Pranit Bauva 2016-08-12 19:25 ` Junio C Hamano 2016-08-13 6:33 ` Pranit Bauva 2016-08-13 7:34 ` Christian Couder 2016-08-13 13:50 ` Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 04/13] bisect--helper: `bisect_clean_state` shell function " Pranit Bauva 2016-08-12 19:24 ` Junio C Hamano 2016-08-10 21:57 ` [PATCH v12 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva 2016-08-10 21:57 ` [PATCH v12 10/13] bisect--helper: `check_and_set_terms` " Pranit Bauva 2016-08-10 22:19 ` [PATCH v12 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 07/13] bisect--helper: `bisect_reset` shell function in C Pranit Bauva 2016-08-19 20:32 ` Pranit Bauva [this message] 2016-08-19 20:32 ` [PATCH v13 02/13] bisect: rewrite `check_term_format` " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 13/13] bisect--helper: `bisect_start` shell function partially " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 08/13] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 09/13] bisect--helper: `bisect_write` " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 12/13] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 04/13] bisect--helper: `bisect_clean_state` " Pranit Bauva 2016-08-21 11:18 ` Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 10/13] bisect--helper: `check_and_set_terms` " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 03/13] bisect--helper: `write_terms` " Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 05/13] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-08-19 20:32 ` [PATCH v13 06/13] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-08-21 11:14 ` [PATCH v13 01/13] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 01/27] " Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 18/27] bisect--helper: `bisect_state` & `bisect_head` shell function in C Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 07/27] bisect--helper: `bisect_reset` " Pranit Bauva 2016-08-24 21:12 ` Junio C Hamano 2016-08-26 13:46 ` Pranit Bauva 2016-08-26 16:29 ` Junio C Hamano 2016-08-27 10:52 ` Pranit Bauva 2016-08-29 17:06 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 16/27] bisect--helper: retire `--next-all` subcommand Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 06/27] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 21/27] bisect--helper: `bisect_log` shell function in C Pranit Bauva 2016-08-26 23:07 ` Junio C Hamano 2016-08-27 20:16 ` Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 09/27] bisect--helper: `bisect_write` " Pranit Bauva 2016-08-24 22:30 ` Junio C Hamano 2016-08-27 9:33 ` Pranit Bauva 2016-08-27 21:22 ` Junio C Hamano 2016-08-30 6:42 ` Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 05/27] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 23/27] bisect--helper: retire `--bisect-write` subcommand Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 11/27] bisect--helper: `bisect_next_check` & bisect_voc shell function in C Pranit Bauva 2016-08-24 22:40 ` Junio C Hamano 2016-08-27 9:35 ` Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 27/27] bisect--helper: remove the dequote in bisect_start() Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 24/27] bisect--helper: retire `--check-and-set-terms` subcommand Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 13/27] bisect--helper: `bisect_start` shell function partially in C Pranit Bauva 2016-08-25 19:02 ` Junio C Hamano 2016-08-25 19:43 ` Junio C Hamano 2016-08-27 19:47 ` Pranit Bauva 2016-08-27 20:53 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 12/27] bisect--helper: `get_terms` & `bisect_terms` shell function " Pranit Bauva 2016-08-25 18:05 ` Junio C Hamano 2016-08-27 9:48 ` Pranit Bauva 2016-08-29 17:15 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 10/27] bisect--helper: `check_and_set_terms` " Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 19/27] bisect--helper: retire `--check-expected-revs` subcommand Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 14/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C Pranit Bauva 2016-08-25 20:30 ` Junio C Hamano 2016-08-30 18:25 ` Pranit Bauva 2016-08-30 18:44 ` Pranit Bauva 2016-08-30 19:33 ` Junio C Hamano 2016-08-30 20:17 ` Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva 2016-08-24 22:13 ` Junio C Hamano 2016-08-27 9:14 ` Pranit Bauva 2016-08-29 17:17 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 15/27] bisect--helper: retire `--bisect-clean-state` subcommand Pranit Bauva 2016-08-26 20:56 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 22/27] bisect--helper: `bisect_replay` shell function in C Pranit Bauva 2016-08-26 23:24 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 03/27] bisect--helper: `write_terms` " Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 17/27] bisect--helper: `bisect_autostart` " Pranit Bauva 2016-08-26 21:09 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 20/27] bisect--helper: retire `--write-terms` subcommand Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 02/27] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 04/27] bisect--helper: `bisect_clean_state` " Pranit Bauva 2016-08-24 20:58 ` Junio C Hamano 2016-08-23 11:53 ` [PATCH v14 25/27] bisect--helper: retire `--bisect-autostart` subcommand Pranit Bauva 2016-08-23 11:53 ` [PATCH v14 26/27] bisect--helper: retire `--bisect-auto-next` subcommand Pranit Bauva 2016-08-23 20:28 ` [PATCH v14 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Junio C Hamano 2016-08-23 21:07 ` Pranit Bauva 2016-08-23 21:24 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 " Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 02/27] bisect: rewrite `check_term_format` shell function in C Pranit Bauva 2016-11-14 22:20 ` Stephan Beyer 2016-11-15 5:16 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 05/27] t6030: explicitly test for bisection cleanup Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 03/27] bisect--helper: `write_terms` shell function in C Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 10/27] bisect--helper: `check_and_set_terms` " Pranit Bauva 2016-11-17 20:25 ` Stephan Beyer 2016-12-06 22:43 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 14/27] t6030: no cleanup with bad merge base Pranit Bauva 2016-10-14 21:43 ` Junio C Hamano 2016-10-15 8:46 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 22/27] bisect--helper: `bisect_log` shell function in C Pranit Bauva 2016-11-17 21:47 ` Stephan Beyer 2016-12-06 22:42 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 17/27] bisect--helper: retire `--next-all` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 25/27] bisect--helper: retire `--bisect-autostart` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 11/27] bisect--helper: `bisect_next_check` & bisect_voc shell function in C Pranit Bauva 2016-11-17 20:59 ` Stephan Beyer 2016-12-06 18:39 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 08/27] bisect--helper: `is_expected_rev` & `check_expected_revs` " Pranit Bauva 2016-11-16 23:47 ` Stephan Beyer 2016-12-06 19:33 ` Pranit Bauva 2016-12-16 19:00 ` Pranit Bauva 2016-12-17 19:42 ` Stephan Beyer 2016-12-16 19:35 ` Pranit Bauva 2016-12-17 19:55 ` Stephan Beyer 2016-10-14 14:14 ` [PATCH v15 06/27] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 15/27] bisect--helper: `bisect_next` and `bisect_auto_next` shell function in C Pranit Bauva 2016-11-20 20:01 ` Stephan Beyer 2016-12-31 10:23 ` Pranit Bauva 2016-11-21 21:35 ` Stephan Beyer 2016-12-31 10:43 ` Pranit Bauva 2017-01-01 16:27 ` Stephan Beyer 2017-01-01 17:41 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 19/27] bisect--helper: `bisect_state` & `bisect_head` " Pranit Bauva 2016-11-22 0:12 ` Stephan Beyer 2016-12-06 22:40 ` Pranit Bauva 2016-12-06 23:54 ` Stephan Beyer 2016-12-08 6:43 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 24/27] bisect--helper: retire `--bisect-write` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 16/27] bisect--helper: retire `--bisect-clean-state` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 09/27] bisect--helper: `bisect_write` shell function in C Pranit Bauva 2016-11-17 9:40 ` Stephan Beyer 2016-12-06 21:32 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 13/27] bisect--helper: `bisect_start` shell function partially " Pranit Bauva 2016-11-15 23:19 ` Stephan Beyer 2016-11-16 17:09 ` Pranit Bauva 2016-11-20 20:01 ` Stephan Beyer 2016-11-20 20:19 ` Stephan Beyer 2016-10-14 14:14 ` [PATCH v15 26/27] bisect--helper: retire `--bisect-auto-next` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 07/27] bisect--helper: `bisect_reset` shell function in C Pranit Bauva 2016-11-16 23:23 ` Stephan Beyer 2016-11-17 3:56 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 27/27] bisect--helper: remove the dequote in bisect_start() Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 04/27] bisect--helper: `bisect_clean_state` shell function in C Pranit Bauva 2016-11-15 21:09 ` Stephan Beyer 2016-11-15 21:40 ` Junio C Hamano 2016-11-15 21:53 ` Stephan Beyer 2016-11-16 16:49 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 21/27] bisect--helper: retire `--write-terms` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 20/27] bisect--helper: retire `--check-expected-revs` subcommand Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 23/27] bisect--helper: `bisect_replay` shell function in C Pranit Bauva 2016-11-22 0:49 ` Stephan Beyer 2016-12-06 23:02 ` Pranit Bauva 2016-12-06 23:20 ` Stephan Beyer 2016-12-06 23:40 ` Stephan Beyer 2016-12-07 13:15 ` Christian Couder 2016-10-14 14:14 ` [PATCH v15 18/27] bisect--helper: `bisect_autostart` " Pranit Bauva 2016-11-20 20:15 ` Stephan Beyer 2016-12-06 19:47 ` Pranit Bauva 2016-10-14 14:14 ` [PATCH v15 12/27] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva 2016-11-17 21:32 ` Stephan Beyer 2016-12-06 21:14 ` Pranit Bauva 2016-12-06 23:05 ` Stephan Beyer 2016-12-07 12:06 ` Pranit Bauva 2016-10-14 15:12 ` [PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Pranit Bauva 2017-09-29 6:49 ` [PATCH v16 1/6] " Pranit Bauva 2017-09-29 6:49 ` [PATCH v16 4/6] bisect--helper: `bisect_clean_state` shell function in C Pranit Bauva 2017-09-29 6:49 ` [PATCH v16 3/6] bisect--helper: `write_terms` " Pranit Bauva 2017-09-29 6:49 ` [PATCH v16 2/6] bisect--helper: rewrite `check_term_format` " Pranit Bauva 2017-09-29 6:49 ` [PATCH v16 5/6] t6030: explicitly test for bisection cleanup Pranit Bauva 2017-09-29 6:49 ` [PATCH v16 6/6] bisect--helper: `is_expected_rev` & `check_expected_revs` shell function in C Pranit Bauva 2017-11-19 20:34 ` Christian Couder 2017-11-20 3:05 ` Junio C Hamano 2017-11-20 7:03 ` Christian Couder 2017-09-29 18:54 ` [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Stephan Beyer 2017-09-29 21:10 ` Pranit Bauva 2017-09-30 12:59 ` Ramsay Jones 2017-10-02 13:44 ` Pranit Bauva 2017-10-03 0:48 ` Ramsay Jones 2017-10-03 3:51 ` Junio C Hamano 2017-10-03 4:35 ` Pranit Bauva 2017-10-04 2:22 ` Ramsay Jones 2017-10-04 4:07 ` Junio C Hamano 2017-10-27 15:06 ` [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C Pranit Bauva 2017-10-27 15:06 ` [PATCH v16 Part II 8/8] t6030: make various test to pass GETTEXT_POISON tests Pranit Bauva 2017-10-27 15:06 ` [PATCH v16 Part II 2/8] bisect--helper: `bisect_write` shell function in C Pranit Bauva 2017-10-27 17:28 ` Martin Ågren 2017-10-30 17:35 ` Pranit Bauva 2018-11-23 10:13 ` Johannes Schindelin 2018-11-23 12:22 ` Martin Ågren 2018-11-26 18:18 ` Johannes Schindelin 2017-10-27 18:19 ` Junio C Hamano 2017-10-30 17:38 ` Pranit Bauva 2017-10-30 13:38 ` Stephan Beyer 2017-10-30 16:24 ` Stephan Beyer 2017-11-08 0:26 ` Ramsay Jones 2017-10-27 15:06 ` [PATCH v16 Part II 7/8] bisect--helper: `bisect_start` shell function partially " Pranit Bauva 2017-10-30 16:51 ` Stephan Beyer 2017-10-30 17:28 ` Pranit Bauva 2018-02-16 1:22 ` SZEDER Gábor 2017-10-27 15:06 ` [PATCH v16 Part II 4/8] bisect--helper: `check_and_set_terms` shell function " Pranit Bauva 2017-11-08 0:37 ` Ramsay Jones 2017-10-27 15:06 ` [PATCH v16 Part II 6/8] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva 2017-10-27 20:04 ` Martin Ågren 2017-10-30 17:45 ` Pranit Bauva 2017-10-30 16:34 ` Stephan Beyer 2017-10-30 17:31 ` Pranit Bauva 2017-11-08 0:59 ` Ramsay Jones 2017-10-27 15:06 ` [PATCH v16 Part II 5/8] bisect--helper: `bisect_next_check` " Pranit Bauva 2017-10-27 17:35 ` Martin Ågren 2017-10-30 17:40 ` Pranit Bauva 2017-11-08 0:48 ` Ramsay Jones 2017-11-12 19:19 ` Stephan Beyer 2017-11-12 19:27 ` Stephan Beyer 2017-11-12 20:03 ` Stephan Beyer 2017-11-13 3:56 ` Junio C Hamano 2017-10-27 15:06 ` [PATCH v16 Part II 3/8] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva 2017-10-27 15:32 ` [PATCH v16 Part II 1/8] bisect--helper: `bisect_reset` shell function in C Pranit Bauva 2017-10-27 17:40 ` Junio C Hamano 2017-10-30 17:26 ` Pranit Bauva 2017-10-30 13:22 ` Stephan Beyer 2017-10-30 17:27 ` Pranit Bauva 2017-11-08 0:07 ` Ramsay Jones 2019-01-02 15:38 ` [PATCH v17 0/7] git bisect: convert from shell to C Tanushree Tumane via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 1/7] bisect--helper: `bisect_reset` shell function in C Pranit Bauva via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 3/7] wrapper: move is_empty_file() and rename it as is_empty_or_missing_file() Pranit Bauva via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 2/7] bisect--helper: `bisect_write` shell function in C Pranit Bauva via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 4/7] bisect--helper: `check_and_set_terms` " Pranit Bauva via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 5/7] bisect--helper: `bisect_next_check` " Pranit Bauva via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 6/7] bisect--helper: `get_terms` & `bisect_terms` " Pranit Bauva via GitGitGadget 2019-01-02 15:38 ` [PATCH v17 7/7] bisect--helper: `bisect_start` shell function partially " Pranit Bauva via GitGitGadget 2019-01-03 1:19 ` [PATCH v17 0/7] git bisect: convert from shell to C Ramsay Jones 2019-01-07 9:15 ` TANUSHREE TUMANE 2016-10-27 16:59 ` [PATCH v15 01/27] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL Junio C Hamano 2016-10-27 20:14 ` Christian Couder 2016-10-28 6:02 ` Matthieu Moy 2016-11-15 21:40 ` Stephan Beyer 2016-11-16 0:18 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=01020156a48145c7-823bdd3d-88da-4e87-9170-9d95b48607dd-000000@eu-west-1.amazonses.com \ --to=pranit.bauva@gmail.com \ --cc=git@vger.kernel.org \ --subject='Re: [PATCH v13 11/13] bisect--helper: `bisect_next_check` & bisect_voc shell function in C' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).