git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org, szeder.dev@gmail.com
Subject: Re: [PATCH v1] travis-ci: fix "skip_branch_tip_with_tag()" string comparison
Date: Fri, 22 Sep 2017 10:57:35 +0900	[thread overview]
Message-ID: <xmqqvakblckw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <4FC081C4-355E-4E62-8CD8-89C299485182@gmail.com> (Lars Schneider's message of "Fri, 22 Sep 2017 00:26:44 +0200")

Lars Schneider <larsxschneider@gmail.com> writes:

> Oh, you're right!
>
>
>> Could you squash in the following?
>
> @Junio: Can you squash it when you apply the patch?

I do not mind and I already did.

The patches in the series this patch is fixing up were solely about
splitting these scripts out of the YAML file as-is, and I think it
was correct to carry these style differences over without adjusting
them.

But resulting scripts in ci/ are riddled with styleguide deviations,
which may want to be cleaned up later.  There also are some
bash-isms marked with "#!env bash" in them, but I think they are OK
because we know we are running them only at a very specific place
and the need to make them portable is very small.

Thanks.

      reply	other threads:[~2017-09-22  1:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 20:48 [PATCH v1] travis-ci: fix "skip_branch_tip_with_tag()" string comparison larsxschneider
2017-09-21 21:28 ` Jonathan Nieder
2017-09-21 22:26   ` Lars Schneider
2017-09-22  1:57     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvakblckw.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=larsxschneider@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).