From: larsxschneider@gmail.com
To: git@vger.kernel.org
Cc: szeder.dev@gmail.com, gitster@pobox.com,
Lars Schneider <larsxschneider@gmail.com>
Subject: [PATCH v1] travis-ci: fix "skip_branch_tip_with_tag()" string comparison
Date: Thu, 21 Sep 2017 22:48:30 +0200 [thread overview]
Message-ID: <20170921204830.66831-1-larsxschneider@gmail.com> (raw)
From: Lars Schneider <larsxschneider@gmail.com>
09f5e97 ("travis-ci: skip a branch build if equal tag is present",
2017-09-17) introduced the "skip_branch_tip_with_tag" function with
a broken string comparison. Fix it!
Reported-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
Hi,
previous discussion:
https://public-inbox.org/git/3B175D35-5B1C-43CD-A7E9-85693335B10A@gmail.com/
Sorry that this trivial fix took so long.
Cheers,
Lars
Notes:
Base Commit: a81423d7cf (a81423d7cfdc57238783f05394dddd1064c99165)
Diff on Web: https://github.com/larsxschneider/git/commit/6b532a42f0
Checkout: git fetch https://github.com/larsxschneider/git travisci/fix-skip-branch-v1 && git checkout 6b532a42f0
ci/lib-travisci.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ci/lib-travisci.sh b/ci/lib-travisci.sh
index 9c4ae9bdd0..c3b46f4a7d 100755
--- a/ci/lib-travisci.sh
+++ b/ci/lib-travisci.sh
@@ -14,7 +14,7 @@ skip_branch_tip_with_tag () {
# of a tag.
if TAG=$(git describe --exact-match "$TRAVIS_BRANCH" 2>/dev/null) &&
- $TAG != $TRAVIS_BRANCH
+ [ "$TAG" != "$TRAVIS_BRANCH" ]
then
echo "Tip of $TRAVIS_BRANCH is exactly at $TAG"
exit 0
--
2.14.1
next reply other threads:[~2017-09-21 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 20:48 larsxschneider [this message]
2017-09-21 21:28 ` [PATCH v1] travis-ci: fix "skip_branch_tip_with_tag()" string comparison Jonathan Nieder
2017-09-21 22:26 ` Lars Schneider
2017-09-22 1:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921204830.66831-1-larsxschneider@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).