From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] fetch: remove fetch_if_missing=0
Date: Sat, 02 Nov 2019 14:55:10 +0900 [thread overview]
Message-ID: <xmqqv9s23jr5.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191101220537.GA249573@google.com> (Jonathan Nieder's message of "Fri, 1 Nov 2019 15:05:37 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> @@ -1755,8 +1756,6 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
>>
>> packet_trace_identity("fetch");
>>
>> - fetch_if_missing = 0;
>> -
>
> This is the scary part, but in an "uncomfortably exciting" sense rather
> than a worrying one. Thanks for adding a test.
>
> [...]
>> --- a/fetch-pack.c
>> +++ b/fetch-pack.c
>> @@ -673,7 +673,8 @@ static void mark_complete_and_common_ref(struct fetch_negotiator *negotiator,
>> struct object *o;
>>
>> if (!has_object_file_with_flags(&ref->old_oid,
>> - OBJECT_INFO_QUICK))
>> + OBJECT_INFO_QUICK |
>> + OBJECT_INFO_SKIP_FETCH_OBJECT))
>
> Should we make OBJECT_INFO_QUICK always imply
> OBJECT_INFO_SKIP_FETCH_OBJECT? I would suspect that if we are willing to
> avoid checking thoroughly locally, checking remotely would be even more
> undesirable.
I think I've seen this mentioned a few times during this cycle in
the list archive ;-)
>> + for i in $(seq 1 100)
>> + do
>> + echo line $i >>big-blob.txt
>> + done &&
>
> Should this use test_seq for better portability?
Yup.
> nit: can avoid a subshell:
>
> test_seq 1 100 | sed -e 's/^/line /' >big-blob.txt
Yeah, but it costs process start-up and "sed" that may be rather
heavyweight. At least
for i in $(test_seq ...)
do
echo line $i
done >big-blob.txt
would save repeated opening and closing the file, I'd think.
>> + git hash-object big-blob.txt >hash &&
>> + grep "want $(cat hash)" trace
>
> nit: can avoid using cat:
>
> hash=$(git hash-object big-blob.txt) &&
> grep "want $hash" trace
>
> Thanks and hope that helps,
Thanks, both.
next prev parent reply other threads:[~2019-11-02 5:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 20:38 [PATCH] fetch: remove fetch_if_missing=0 Jonathan Tan
2019-11-01 22:05 ` Jonathan Nieder
2019-11-02 5:55 ` Junio C Hamano [this message]
2019-11-02 6:11 ` Eric Sunshine
2019-11-02 5:59 ` Junio C Hamano
2019-11-05 18:53 ` Jonathan Tan
2019-11-05 18:58 ` Jonathan Nieder
2019-11-05 18:56 ` [PATCH v2] " Jonathan Tan
2019-11-05 20:06 ` Eric Sunshine
2019-11-06 1:45 ` Junio C Hamano
2019-11-08 6:33 ` Junio C Hamano
2019-11-08 7:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9s23jr5.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).