From: Eric Sunshine <sunshine@sunshineco.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: Git List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] fetch: remove fetch_if_missing=0
Date: Tue, 5 Nov 2019 15:06:13 -0500 [thread overview]
Message-ID: <CAPig+cQ6iyJacniLDF_kuc1FhPMXYmL3V1DzdOPa6bX0h2FHFA@mail.gmail.com> (raw)
In-Reply-To: <20191105185619.207173-1-jonathantanmy@google.com>
On Tue, Nov 5, 2019 at 1:56 PM Jonathan Tan <jonathantanmy@google.com> wrote:
> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
> @@ -296,6 +296,76 @@ test_expect_success 'partial clone with unresolvable sparse filter fails cleanly
> +setup_triangle () {
> + rm -rf big-blob.txt server client promisor-remote &&
> +
> + printf "line %d\n" $(test_seq 1 100) >big-blob.txt
Broken &&-chain.
> + # Create a server with 2 commits: a commit with a big blob and a child
> + # commit with an incremental change. Also, create a partial clone
> + # client that only contains the first commit.
> + git init server &&
> + git -C server config --local uploadpack.allowfilter 1 &&
> + cp big-blob.txt server &&
> + git -C server add big-blob.txt &&
> + git -C server commit -m "initial" &&
> + git clone --bare --filter=tree:0 "file://$(pwd)/server" client &&
> + echo another line >>server/big-blob.txt &&
> + git -C server commit -am "append line to big blob" &&
> +
> + # Create a promisor remote that only contains the blob from the first
> + # commit, and set it as the promisor remote of client. Thus, whenever
> + # the client lazy fetches, the lazy fetch will succeed only if it is
> + # for this blob.
> + git init promisor-remote &&
> + test_commit -C promisor-remote one && # so that ref advertisement is not empty
> + git -C promisor-remote config --local uploadpack.allowanysha1inwant 1 &&
> + git -C promisor-remote hash-object -w --stdin <big-blob.txt &&
> + git -C client remote set-url origin "file://$(pwd)/promisor-remote"
> +}
next prev parent reply other threads:[~2019-11-05 20:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 20:38 [PATCH] fetch: remove fetch_if_missing=0 Jonathan Tan
2019-11-01 22:05 ` Jonathan Nieder
2019-11-02 5:55 ` Junio C Hamano
2019-11-02 6:11 ` Eric Sunshine
2019-11-02 5:59 ` Junio C Hamano
2019-11-05 18:53 ` Jonathan Tan
2019-11-05 18:58 ` Jonathan Nieder
2019-11-05 18:56 ` [PATCH v2] " Jonathan Tan
2019-11-05 20:06 ` Eric Sunshine [this message]
2019-11-06 1:45 ` Junio C Hamano
2019-11-08 6:33 ` Junio C Hamano
2019-11-08 7:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQ6iyJacniLDF_kuc1FhPMXYmL3V1DzdOPa6bX0h2FHFA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).