From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: "René Scharfe" <l.s.r@web.de>,
"Git Mailing List" <git@vger.kernel.org>,
"Alban Gruin" <alban.gruin@gmail.com>
Subject: Re: [PATCH] rebase: remove unused function reschedule_last_action
Date: Wed, 12 Aug 2020 12:25:15 -0700 [thread overview]
Message-ID: <xmqqv9hn650k.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200812134827.GB74542@syl.lan> (Taylor Blau's message of "Wed, 12 Aug 2020 09:48:27 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote:
>> The only caller of reschedule_last_action was removed by ef64bb328df
>> (rebase: strip unused code in git-rebase--preserve-merges.sh,
>> 2018-05-28); remove this unused shell function as well.
>
> Easy peasy ;-). Obviously correct, and thanks for cleaning this up.
>
> Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
I thought preserve-merges backend is on its way out, but I do not
have objection to have some part of it retire earlier than the
remainder of it ;-)
Will queue. Thanks.
>> ---
>> git-rebase--preserve-merges.sh | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh
>> index dec90e9af67..b9c71d2a71b 100644
>> --- a/git-rebase--preserve-merges.sh
>> +++ b/git-rebase--preserve-merges.sh
>> @@ -193,16 +193,6 @@ mark_action_done () {
>> fi
>> }
>>
>> -# Put the last action marked done at the beginning of the todo list
>> -# again. If there has not been an action marked done yet, leave the list of
>> -# items on the todo list unchanged.
>> -reschedule_last_action () {
>> - tail -n 1 "$done" | cat - "$todo" >"$todo".new
>> - sed -e \$d <"$done" >"$done".new
>> - mv -f "$todo".new "$todo"
>> - mv -f "$done".new "$done"
>> -}
>> -
>> append_todo_help () {
>> gettext "
>> Commands:
>> --
>> 2.28.0
>
> Thanks,
> Taylor
prev parent reply other threads:[~2020-08-12 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 13:45 [PATCH] rebase: remove unused function reschedule_last_action René Scharfe
2020-08-12 13:48 ` Taylor Blau
2020-08-12 19:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9hn650k.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).