* [PATCH] rebase: remove unused function reschedule_last_action
@ 2020-08-12 13:45 René Scharfe
2020-08-12 13:48 ` Taylor Blau
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2020-08-12 13:45 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, Alban Gruin
The only caller of reschedule_last_action was removed by ef64bb328df
(rebase: strip unused code in git-rebase--preserve-merges.sh,
2018-05-28); remove this unused shell function as well.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
git-rebase--preserve-merges.sh | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh
index dec90e9af67..b9c71d2a71b 100644
--- a/git-rebase--preserve-merges.sh
+++ b/git-rebase--preserve-merges.sh
@@ -193,16 +193,6 @@ mark_action_done () {
fi
}
-# Put the last action marked done at the beginning of the todo list
-# again. If there has not been an action marked done yet, leave the list of
-# items on the todo list unchanged.
-reschedule_last_action () {
- tail -n 1 "$done" | cat - "$todo" >"$todo".new
- sed -e \$d <"$done" >"$done".new
- mv -f "$todo".new "$todo"
- mv -f "$done".new "$done"
-}
-
append_todo_help () {
gettext "
Commands:
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rebase: remove unused function reschedule_last_action
2020-08-12 13:45 [PATCH] rebase: remove unused function reschedule_last_action René Scharfe
@ 2020-08-12 13:48 ` Taylor Blau
2020-08-12 19:25 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Taylor Blau @ 2020-08-12 13:48 UTC (permalink / raw)
To: René Scharfe; +Cc: Git Mailing List, Junio C Hamano, Alban Gruin
On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote:
> The only caller of reschedule_last_action was removed by ef64bb328df
> (rebase: strip unused code in git-rebase--preserve-merges.sh,
> 2018-05-28); remove this unused shell function as well.
Easy peasy ;-). Obviously correct, and thanks for cleaning this up.
Reviewed-by: Taylor Blau <me@ttaylorr.com>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> git-rebase--preserve-merges.sh | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh
> index dec90e9af67..b9c71d2a71b 100644
> --- a/git-rebase--preserve-merges.sh
> +++ b/git-rebase--preserve-merges.sh
> @@ -193,16 +193,6 @@ mark_action_done () {
> fi
> }
>
> -# Put the last action marked done at the beginning of the todo list
> -# again. If there has not been an action marked done yet, leave the list of
> -# items on the todo list unchanged.
> -reschedule_last_action () {
> - tail -n 1 "$done" | cat - "$todo" >"$todo".new
> - sed -e \$d <"$done" >"$done".new
> - mv -f "$todo".new "$todo"
> - mv -f "$done".new "$done"
> -}
> -
> append_todo_help () {
> gettext "
> Commands:
> --
> 2.28.0
Thanks,
Taylor
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rebase: remove unused function reschedule_last_action
2020-08-12 13:48 ` Taylor Blau
@ 2020-08-12 19:25 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2020-08-12 19:25 UTC (permalink / raw)
To: Taylor Blau; +Cc: René Scharfe, Git Mailing List, Alban Gruin
Taylor Blau <me@ttaylorr.com> writes:
> On Wed, Aug 12, 2020 at 03:45:47PM +0200, René Scharfe wrote:
>> The only caller of reschedule_last_action was removed by ef64bb328df
>> (rebase: strip unused code in git-rebase--preserve-merges.sh,
>> 2018-05-28); remove this unused shell function as well.
>
> Easy peasy ;-). Obviously correct, and thanks for cleaning this up.
>
> Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
I thought preserve-merges backend is on its way out, but I do not
have objection to have some part of it retire earlier than the
remainder of it ;-)
Will queue. Thanks.
>> ---
>> git-rebase--preserve-merges.sh | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/git-rebase--preserve-merges.sh b/git-rebase--preserve-merges.sh
>> index dec90e9af67..b9c71d2a71b 100644
>> --- a/git-rebase--preserve-merges.sh
>> +++ b/git-rebase--preserve-merges.sh
>> @@ -193,16 +193,6 @@ mark_action_done () {
>> fi
>> }
>>
>> -# Put the last action marked done at the beginning of the todo list
>> -# again. If there has not been an action marked done yet, leave the list of
>> -# items on the todo list unchanged.
>> -reschedule_last_action () {
>> - tail -n 1 "$done" | cat - "$todo" >"$todo".new
>> - sed -e \$d <"$done" >"$done".new
>> - mv -f "$todo".new "$todo"
>> - mv -f "$done".new "$done"
>> -}
>> -
>> append_todo_help () {
>> gettext "
>> Commands:
>> --
>> 2.28.0
>
> Thanks,
> Taylor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-12 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 13:45 [PATCH] rebase: remove unused function reschedule_last_action René Scharfe
2020-08-12 13:48 ` Taylor Blau
2020-08-12 19:25 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).