git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* Obsolete instruction in SubmittingPatches?
@ 2018-02-28 21:31 Andrei Rybak
  2018-02-28 21:54 ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Andrei Rybak @ 2018-02-28 21:31 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

Hello,

It seems to me that this part of Documentation/SubmittingPatches is
not actual nowadays:

  After the list reached a consensus that it is a good idea to apply the
  patch, re-send it with "To:" set to the maintainer{1} and "cc:" the
  list{2} for inclusion.

From what I observe in the mailing list, most patches are sent with
"To:" set to mailing list (or re-sent with increasing version) , as per
previous paragraph in the guidelines [1].  Then, after the topic is
reviewed and the [PATCH v<last>] series receives a thumbs up from a
number of people, the maintainer--Junio C Hamano--replies with an email
containing something along the lines of "This change is in good
shape.  Thanks, will queue.", which makes me think that the re-send
is not actually needed.

Is this part of guidelines obsolete, or am I not understanding this
correctly?

[1] "Send your patch with "To:" set to the mailing list, with "cc:"
    listing people who are involved in the area you are touching"

--
Best regards, Andrei Rybak

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Obsolete instruction in SubmittingPatches?
  2018-02-28 21:31 Obsolete instruction in SubmittingPatches? Andrei Rybak
@ 2018-02-28 21:54 ` Junio C Hamano
  2018-03-01 17:29   ` Andrei Rybak
  0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2018-02-28 21:54 UTC (permalink / raw)
  To: Andrei Rybak; +Cc: git

Andrei Rybak <rybak.a.v@gmail.com> writes:

> Is this part of guidelines obsolete, or am I not understanding this
> correctly?

I am merely being nice (but only on "time-permitting" basis).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Obsolete instruction in SubmittingPatches?
  2018-02-28 21:54 ` Junio C Hamano
@ 2018-03-01 17:29   ` Andrei Rybak
  2018-03-01 21:43     ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Andrei Rybak @ 2018-03-01 17:29 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On 01.03.2018 0:54, Junio C Hamano wrote:
> Andrei Rybak <rybak.a.v@gmail.com> writes:
> 
>> Is this part of guidelines obsolete, or am I not understanding this
>> correctly?
> 
> I am merely being nice (but only on "time-permitting" basis).
> 

Does that mean that the integration of a series is easier, when there is
a re-send?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Obsolete instruction in SubmittingPatches?
  2018-03-01 17:29   ` Andrei Rybak
@ 2018-03-01 21:43     ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2018-03-01 21:43 UTC (permalink / raw)
  To: Andrei Rybak; +Cc: git

Andrei Rybak <rybak.a.v@gmail.com> writes:

> On 01.03.2018 0:54, Junio C Hamano wrote:
>> Andrei Rybak <rybak.a.v@gmail.com> writes:
>> 
>>> Is this part of guidelines obsolete, or am I not understanding this
>>> correctly?
>> 
>> I am merely being nice (but only on "time-permitting" basis).
>
> Does that mean that the integration of a series is easier, when there is
> a re-send?

When I am not interested in a topic, or there are other reviewers
who are more qualified and are interested in the topic than I am,
the protocol to require the final "Here is a verbatim final resend,
the only difference from what was reviewed is the reviewed-by's from
the reviewers." will let me completely ignore the topic while it is
being discussed (as long as I trust the judgment of these reviewers).

Otherwise I'd need to keep track of the progress of the discussion
on each and every topic, which is often impossible.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-03-01 21:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-28 21:31 Obsolete instruction in SubmittingPatches? Andrei Rybak
2018-02-28 21:54 ` Junio C Hamano
2018-03-01 17:29   ` Andrei Rybak
2018-03-01 21:43     ` Junio C Hamano

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).