From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>, Elijah Newren <newren@gmail.com>,
Shourya Shukla <shouryashukla.oo@gmail.com>
Subject: Re: [PATCH v2] test_cmp: diagnose incorrect arguments
Date: Mon, 10 Aug 2020 08:22:59 -0700 [thread overview]
Message-ID: <xmqqtuxacyp8.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cTA_BVz-bGcGY++g2RV-Zd3Gv_yTGjv=VeMeqhP4eZZrw@mail.gmail.com> (Eric Sunshine's message of "Sun, 9 Aug 2020 15:34:57 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> I had the same concern that it didn't necessarily make sense to allow
> "-" for $2, but eventually thought of a case such as:
>
> sed '...' actual | test_cmp expect - &&
>
> which massages 'actual' before test_cmp() sees it. True, we don't
> actually have such callers, but it theoretically is legitimate.
Yup, that looks a bit too stretching [*] to me, but that was what I
had in mind when I said "I'll let it pass".
Side note. Presumably that 'actual' was written by Git, to
avoid losing its exit code, e.g.
git frotz >actual &&
sed '...' actual | test_cmp expect -
but then it becomes more natural to write the second one like
so:
git frotz >raw &&
sed '...' raw >actual &&
test_cmp expect actual
next prev parent reply other threads:[~2020-08-10 15:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 6:08 [PATCH] test_cmp: diagnose incorrect arguments Eric Sunshine
2020-08-09 8:32 ` Shourya Shukla
2020-08-09 8:49 ` Eric Sunshine
2020-08-09 17:42 ` [PATCH v2] " Eric Sunshine
2020-08-09 19:12 ` Junio C Hamano
2020-08-09 19:34 ` Eric Sunshine
2020-08-10 15:22 ` Junio C Hamano [this message]
2020-08-11 18:32 ` Taylor Blau
2020-08-11 19:25 ` Eric Sunshine
2020-08-11 21:03 ` Taylor Blau
2020-08-12 15:37 ` Jeff King
2020-08-12 16:15 ` Eric Sunshine
2020-08-12 16:39 ` Eric Sunshine
2020-08-12 17:10 ` Jeff King
2020-10-16 0:17 ` Jeff King
2020-10-16 2:18 ` Eric Sunshine
2020-10-16 18:36 ` Junio C Hamano
2020-10-16 20:56 ` Junio C Hamano
2020-10-16 23:14 ` Junio C Hamano
2020-10-17 6:06 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuxacyp8.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=shouryashukla.oo@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).