From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Fabian Stelzer" <fs@gigacodes.de>,
"Git List" <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Randall Becker" <rsbecker@nexbridge.com>,
"Baruch Burstein" <bmburstein@gmail.com>
Subject: Re: [PATCH] CodingGuidelines: document which output goes to stdout vs. stderr
Date: Wed, 01 Dec 2021 13:35:53 -0800 [thread overview]
Message-ID: <xmqqtufsypmu.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cRFqO5wcZTPrpTuiBP72+6enJs+---mjT2AFAQq5ztt_w@mail.gmail.com> (Eric Sunshine's message of "Wed, 1 Dec 2021 08:50:47 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> However, I can certainly change these to say "Git command" if you
> think it would make the intent clearer, and can update the final point
> to say:
>
> Error messages from Git commands should always
> be sent to the stderr stream.
In an earlier round, I think there was a version without "should" in
there, but I am sure we have bugs that do not follow the guideline.
The proposed phrasing sounds good to me.
Thanks.
next prev parent reply other threads:[~2021-12-01 21:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 5:32 [PATCH] CodingGuidelines: document which output goes to stdout vs. stderr Eric Sunshine
2021-12-01 8:33 ` Fabian Stelzer
2021-12-01 13:50 ` Eric Sunshine
2021-12-01 15:14 ` Fabian Stelzer
2021-12-01 21:35 ` Junio C Hamano [this message]
2021-12-01 21:57 ` Eric Sunshine
2021-12-01 19:42 ` Jeff King
2021-12-01 20:30 ` Eric Sunshine
2021-12-01 23:27 ` Philip Oakley
2021-12-01 23:56 ` Eric Sunshine
2021-12-02 22:31 ` [PATCH v2] " Eric Sunshine
2021-12-02 23:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtufsypmu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bmburstein@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).