git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: "Git List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Randall Becker" <rsbecker@nexbridge.com>,
	"Baruch Burstein" <bmburstein@gmail.com>
Subject: Re: [PATCH] CodingGuidelines: document which output goes to stdout vs. stderr
Date: Wed, 1 Dec 2021 15:30:12 -0500	[thread overview]
Message-ID: <CAPig+cS3Ymnfeob0UREvpvR0w7uKA7WnVqMn+ZNYOjx35x1p-Q@mail.gmail.com> (raw)
In-Reply-To: <YafQMTsU2+vLNalY@coredump.intra.peff.net>

On Wed, Dec 1, 2021 at 2:42 PM Jeff King <peff@peff.net> wrote:
> On Wed, Dec 01, 2021 at 12:32:14AM -0500, Eric Sunshine wrote:
> > It has long been practice in this project for a command to emit its
> > primary output to stdout so that it can be captured to a file or sent
> > down a pipe, and to emit "chatty" messages (such as those reporting
> > progress) to stderr so that they don't interfere with the primary
> > output. However, this idiomatic Unix practice is not necessarily
> > universally understood and may be at odds with other schools of thought,
> > such as the somewhat common one that only error messages should go to
> > stderr, and all other messages to stdout. Let's help newcomers by
> > documenting how stdout and stderr are used on this project.
>
> I agree with everything you wrote here and below, which I think captures
> what we want to communicate to folks adding new messages or commands.
>
> I am not quite sure _everyone_ would agree with "this idiomatic Unix
> practice" above. It does seem to be a matter of taste (it is just that
> what you wrote very much agrees with my taste :) ). And "idiomatic Unix
> practice" is probably not to be chatty at all, but I think that has been
> changing over the years.
>
> So I'm not sure if your commit message is being nicely assertive about
> its taste, or is being uncharitable to people who may have different
> tastes (but again, IMHO we should pick a direction and this seems like
> the best one to me). :)

Thanks for the feedback. I'll tone down the commit message when I
reroll to make the patch text spell out "Git command" explicitly so
that it's less likely to mislead the reader (as it misled Fabian) into
thinking the new guideline applies to all output, including test
output.

  reply	other threads:[~2021-12-01 20:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  5:32 [PATCH] CodingGuidelines: document which output goes to stdout vs. stderr Eric Sunshine
2021-12-01  8:33 ` Fabian Stelzer
2021-12-01 13:50   ` Eric Sunshine
2021-12-01 15:14     ` Fabian Stelzer
2021-12-01 21:35     ` Junio C Hamano
2021-12-01 21:57       ` Eric Sunshine
2021-12-01 19:42 ` Jeff King
2021-12-01 20:30   ` Eric Sunshine [this message]
2021-12-01 23:27 ` Philip Oakley
2021-12-01 23:56   ` Eric Sunshine
2021-12-02 22:31 ` [PATCH v2] " Eric Sunshine
2021-12-02 23:58   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cS3Ymnfeob0UREvpvR0w7uKA7WnVqMn+ZNYOjx35x1p-Q@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=avarab@gmail.com \
    --cc=bmburstein@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).