From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: John Cai via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, me@ttaylorr.com, avarab@gmail.com,
e@80x24.org, bagasdotme@gmail.com,
Eric Sunshine <sunshine@sunshineco.com>,
Jonathan Tan <jonathantanmy@google.com>,
Christian Couder <christian.couder@gmail.com>,
John Cai <johncai86@gmail.com>
Subject: Re: [PATCH v9 4/4] cat-file: add --batch-command mode
Date: Fri, 18 Feb 2022 09:23:07 -0800 [thread overview]
Message-ID: <xmqqtucw2io4.fsf@gitster.g> (raw)
In-Reply-To: <095278d4-217b-7d97-5364-9cd491b34ed0@gmail.com> (Phillip Wood's message of "Fri, 18 Feb 2022 11:26:10 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> This is looking good. I think the only thing that is missing (and
> which I should have realized earlier) is that there are no tests for
> valid or invalid format arguments to --batch-command. I haven't
> checked but there must be some other tests in the t1006 that we can
> piggy back on to add that. I've left some stylistic comments below but
> I don't fell strongly about them apart from the README comment so
> please don't feel obliged to act on them, it's looking pretty good as
> is.
Yes, I agree that this is mostly good. I also agree with all the
points you raised in your review, including the stylistic ones.
next prev parent reply other threads:[~2022-02-18 17:23 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 19:08 [PATCH 0/2] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-03 19:08 ` [PATCH 1/2] cat-file.c: rename cmdmode to mode John Cai via GitGitGadget
2022-02-03 19:28 ` Junio C Hamano
2022-02-04 12:10 ` Ævar Arnfjörð Bjarmason
2022-02-03 19:08 ` [PATCH 2/2] catfile.c: add --batch-command mode John Cai via GitGitGadget
2022-02-03 19:57 ` Junio C Hamano
2022-02-04 4:11 ` John Cai
2022-02-04 16:46 ` Phillip Wood
2022-02-04 6:45 ` Eric Sunshine
2022-02-04 21:41 ` John Cai
2022-02-05 6:52 ` Eric Sunshine
2022-02-04 12:11 ` Ævar Arnfjörð Bjarmason
2022-02-04 16:51 ` Phillip Wood
2022-02-07 16:33 ` [PATCH v2 0/2] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-07 16:33 ` [PATCH v2 1/2] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-07 23:58 ` Junio C Hamano
2022-02-07 16:33 ` [PATCH v2 2/2] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-07 23:34 ` Jonathan Tan
2022-02-08 11:00 ` Phillip Wood
2022-02-08 17:56 ` Jonathan Tan
2022-02-08 18:09 ` Junio C Hamano
2022-02-09 0:11 ` Jonathan Tan
2022-02-08 0:49 ` Junio C Hamano
2022-02-08 11:06 ` Phillip Wood
2022-02-08 20:58 ` [PATCH v3 0/3] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-08 20:58 ` [PATCH v3 1/3] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-08 20:58 ` [PATCH v3 2/3] cat-file: introduce batch_command enum to replace print_contents John Cai via GitGitGadget
2022-02-08 23:43 ` Junio C Hamano
2022-02-08 20:58 ` [PATCH v3 3/3] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-08 23:59 ` Junio C Hamano
2022-02-09 21:40 ` [PATCH v3 0/3] Add cat-file --batch-command flag Junio C Hamano
2022-02-09 22:22 ` John Cai
2022-02-09 23:10 ` John Cai
2022-02-10 4:01 ` [PATCH v4 " John Cai via GitGitGadget
2022-02-10 4:01 ` [PATCH v4 1/3] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-10 4:01 ` [PATCH v4 2/3] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-10 10:10 ` Christian Couder
2022-02-10 4:01 ` [PATCH v4 3/3] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-10 10:57 ` Phillip Wood
2022-02-10 17:05 ` Junio C Hamano
2022-02-11 17:45 ` John Cai
2022-02-11 20:07 ` Junio C Hamano
2022-02-11 21:30 ` John Cai
2022-02-10 18:55 ` John Cai
2022-02-10 22:46 ` Eric Sunshine
2022-02-10 20:30 ` [PATCH v4 0/3] Add cat-file --batch-command flag Junio C Hamano
2022-02-11 20:01 ` [PATCH v5 " John Cai via GitGitGadget
2022-02-11 20:01 ` [PATCH v5 1/3] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-11 20:01 ` [PATCH v5 2/3] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-11 20:01 ` [PATCH v5 3/3] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-14 13:59 ` Phillip Wood
2022-02-14 16:19 ` John Cai
2022-02-14 18:23 ` [PATCH v6 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-14 18:23 ` [PATCH v6 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-15 19:39 ` Eric Sunshine
2022-02-15 22:58 ` John Cai
2022-02-15 23:20 ` Eric Sunshine
2022-02-16 0:53 ` [PATCH v7 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-16 0:53 ` [PATCH v7 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-16 1:28 ` Junio C Hamano
2022-02-16 2:48 ` John Cai
2022-02-16 3:00 ` Junio C Hamano
2022-02-16 3:17 ` Eric Sunshine
2022-02-16 3:01 ` Eric Sunshine
2022-02-16 15:02 ` [PATCH v8 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-16 15:02 ` [PATCH v8 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-16 17:15 ` Junio C Hamano
2022-02-16 17:25 ` Eric Sunshine
2022-02-16 20:30 ` John Cai
2022-02-16 20:59 ` [PATCH v9 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-16 20:59 ` [PATCH v9 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-18 11:26 ` Phillip Wood
2022-02-18 16:53 ` John Cai
2022-02-18 17:32 ` Junio C Hamano
2022-02-18 17:23 ` Junio C Hamano [this message]
2022-02-18 18:23 ` [PATCH v10 0/4] Add cat-file --batch-command flag John Cai via GitGitGadget
2022-02-18 18:23 ` [PATCH v10 1/4] cat-file: rename cmdmode to transform_mode John Cai via GitGitGadget
2022-02-18 18:23 ` [PATCH v10 2/4] cat-file: introduce batch_mode enum to replace print_contents John Cai via GitGitGadget
2022-02-18 18:23 ` [PATCH v10 3/4] cat-file: add remove_timestamp helper John Cai via GitGitGadget
2022-02-19 6:33 ` Ævar Arnfjörð Bjarmason
2022-02-22 3:31 ` John Cai
2022-02-18 18:23 ` [PATCH v10 4/4] cat-file: add --batch-command mode John Cai via GitGitGadget
2022-02-19 6:35 ` Ævar Arnfjörð Bjarmason
2022-02-18 19:38 ` [PATCH v10 0/4] Add cat-file --batch-command flag Junio C Hamano
2022-02-22 11:07 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtucw2io4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=christian.couder@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).