From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: tm-uzr3z@entrap.de, git@vger.kernel.org
Subject: Re: [PATCH] add basic http proxy tests
Date: Thu, 16 Feb 2023 16:30:28 -0800 [thread overview]
Message-ID: <xmqqttzlm8uz.fsf@gitster.g> (raw)
In-Reply-To: <Y+6YgALh6L9m6rSX@coredump.intra.peff.net> (Jeff King's message of "Thu, 16 Feb 2023 15:56:32 -0500")
Jeff King <peff@peff.net> writes:
> Here is that patch. Even though it didn't lead me anywhere useful in
> debugging your problem, it may be worth picking up anyway just to get
> better test coverage.
> ...
> - I'm using a single apache instance to proxy to itself. This seems to
> work fine in practice, and we can check with a test that this rather
> unusual setup is doing what we expect.
Cute.
> - I've put the proxy tests into their own script, and it's the only
> one which loads the apache proxy config. If any platform can't
> handle this (e.g., doesn't have the right modules), the start_httpd
> step should fail and gracefully skip the rest of the script (but all
> the other http tests in existing scripts will continue to run).
Nice. I have to move it from 5563 to 5564, though.
> - On the client side, we test two situations with credentials: when
> they are present in the url, and when the username is present but we
> prompt for the password. I think we should be able to handle the
> case that _neither_ is present, but an HTTP 407 causes us to prompt
> for them. However, this doesn't seem to work. That's either a bug,
> or at the very least an opportunity for a feature, but I punted on
> it for now. The point of this patch is just getting basic coverage,
> and we can explore possible deficiencies later.
OK.
Thanks.
next prev parent reply other threads:[~2023-02-17 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 17:55 Bug: git behind proxy is broken in 2.34.1 tm-uzr3z
2023-02-16 20:46 ` Jeff King
2023-02-16 20:56 ` [PATCH] add basic http proxy tests Jeff King
2023-02-17 0:30 ` Junio C Hamano [this message]
2023-02-17 0:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttzlm8uz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tm-uzr3z@entrap.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).