From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: tm-uzr3z@entrap.de, git@vger.kernel.org
Subject: Re: [PATCH] add basic http proxy tests
Date: Thu, 16 Feb 2023 19:43:45 -0500 [thread overview]
Message-ID: <Y+7NwQer53hP9ekm@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqttzlm8uz.fsf@gitster.g>
On Thu, Feb 16, 2023 at 04:30:28PM -0800, Junio C Hamano wrote:
> > - I've put the proxy tests into their own script, and it's the only
> > one which loads the apache proxy config. If any platform can't
> > handle this (e.g., doesn't have the right modules), the start_httpd
> > step should fail and gracefully skip the rest of the script (but all
> > the other http tests in existing scripts will continue to run).
>
> Nice. I have to move it from 5563 to 5564, though.
Ah, yeah. These number collisions are annoying.
Also, I note that our http client tests have spilled over into t556x
now, making the t556x_common script a bit of a misnomer (it handles
http-backend stuff). I'm not sure if we should be reordering more (which
is a lot of hassle) or perhaps just giving that helper a script a more
descriptive name. Or doing nothing. It is not that big a deal, just
something I noticed while searching for an unused number.
-Peff
prev parent reply other threads:[~2023-02-17 0:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 17:55 Bug: git behind proxy is broken in 2.34.1 tm-uzr3z
2023-02-16 20:46 ` Jeff King
2023-02-16 20:56 ` [PATCH] add basic http proxy tests Jeff King
2023-02-17 0:30 ` Junio C Hamano
2023-02-17 0:43 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+7NwQer53hP9ekm@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tm-uzr3z@entrap.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).