From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] cmake: ignore generated files
Date: Wed, 23 Sep 2020 10:47:32 -0700 [thread overview]
Message-ID: <xmqqsgb8idvv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.735.git.1600375065498.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Thu, 17 Sep 2020 20:37:45 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When using CMake to generate the files required to build Git in Visual
> Studio, a bunch of files are generated. We will want to prevent them
> from being tracked in Git.
If we were to go this route, let's
* update the log message to say that we assume we will use CMake to
build in-place.
* update the comment in the top part of the CMakeList.txt that
suggests it is a possibility to use it from subdirectories.
* optionally, update the same comment to recommend "clean -xdf"
as a way to bring the source tree back to the pristine state.
Will queue with a tentative attempt to do the first bullet point to
save one roundtip, something like:
When using CMake to generate the files required to build Git
in-place for Visual Studio, ...
Other two points needs help from others (iow, I won't do so myself
right now).
Thanks.
next prev parent reply other threads:[~2020-09-23 17:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 20:37 [PATCH] cmake: ignore generated files Johannes Schindelin via GitGitGadget
2020-09-17 21:49 ` Junio C Hamano
2020-09-18 13:11 ` Johannes Schindelin
2020-09-18 15:28 ` Junio C Hamano
2020-09-18 15:50 ` Đoàn Trần Công Danh
2020-09-18 16:21 ` Junio C Hamano
2020-09-19 0:40 ` Đoàn Trần Công Danh
2020-09-19 0:50 ` Junio C Hamano
2020-09-20 17:37 ` Johannes Schindelin
2020-09-23 15:59 ` Junio C Hamano
2020-09-23 20:27 ` Johannes Schindelin
2020-09-23 20:38 ` Junio C Hamano
2020-09-25 6:40 ` Johannes Schindelin
2020-09-24 10:34 ` Đoàn Trần Công Danh
2020-09-25 5:02 ` Johannes Schindelin
2020-09-20 17:15 ` Johannes Schindelin
2020-09-21 22:46 ` Junio C Hamano
2020-09-23 13:08 ` Johannes Schindelin
2020-09-24 9:19 ` SZEDER Gábor
2020-09-24 17:11 ` Junio C Hamano
2020-09-23 17:47 ` Junio C Hamano [this message]
2020-09-23 17:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsgb8idvv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).