From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] cmake: ignore generated files
Date: Fri, 18 Sep 2020 15:11:11 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2009181510240.5061@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqtuvwoyz5.fsf@gitster.c.googlers.com>
Hi Junio,
On Thu, 17 Sep 2020, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > When using CMake to generate the files required to build Git in Visual
> > Studio, a bunch of files are generated. We will want to prevent them
> > from being tracked in Git.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > Ignore files generated by CMake
> >
> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-735%2Fdscho%2Fignore-generated-cmake-files-v1
> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-735/dscho/ignore-generated-cmake-files-v1
> > Pull-Request: https://github.com/gitgitgadget/git/pull/735
> >
> > .gitignore | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 9673e792db..36f5ac4138 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -239,3 +239,9 @@ Release/
> > /git.VC.VC.opendb
> > /git.VC.db
> > *.dSYM
> > +*.vcxproj
> > +*.vcxproj.filters
> > +/CMakeCache.txt
> > +/CMakeFiles/
> > +/*.cmake
> > +/DartConfiguration.tcl
>
> Good to catch these cruft.
>
> Does the equivalent of "make distclean" need to be updated to clean
> them as well, or is it sufficient to ignore the build procedure and
> just rely on "git clean -f -x"?
Since CMake in conjunction with Visual Studio completely side-steps
`make`, I think it would make most sense to ignore `make distclean` in
this context and go for `git clean -dfx` instead.
Ciao,
Dscho
next prev parent reply other threads:[~2020-09-18 13:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 20:37 [PATCH] cmake: ignore generated files Johannes Schindelin via GitGitGadget
2020-09-17 21:49 ` Junio C Hamano
2020-09-18 13:11 ` Johannes Schindelin [this message]
2020-09-18 15:28 ` Junio C Hamano
2020-09-18 15:50 ` Đoàn Trần Công Danh
2020-09-18 16:21 ` Junio C Hamano
2020-09-19 0:40 ` Đoàn Trần Công Danh
2020-09-19 0:50 ` Junio C Hamano
2020-09-20 17:37 ` Johannes Schindelin
2020-09-23 15:59 ` Junio C Hamano
2020-09-23 20:27 ` Johannes Schindelin
2020-09-23 20:38 ` Junio C Hamano
2020-09-25 6:40 ` Johannes Schindelin
2020-09-24 10:34 ` Đoàn Trần Công Danh
2020-09-25 5:02 ` Johannes Schindelin
2020-09-20 17:15 ` Johannes Schindelin
2020-09-21 22:46 ` Junio C Hamano
2020-09-23 13:08 ` Johannes Schindelin
2020-09-24 9:19 ` SZEDER Gábor
2020-09-24 17:11 ` Junio C Hamano
2020-09-23 17:47 ` Junio C Hamano
2020-09-23 17:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2009181510240.5061@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).