git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Orgad Shaneh <orgads@gmail.com>
Subject: Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog
Date: Sun, 21 Apr 2024 11:29:10 -0700	[thread overview]
Message-ID: <xmqqseze1seh.fsf@gitster.g> (raw)
In-Reply-To: <pull.1711.git.git.1713642690371.gitgitgadget@gmail.com> (Orgad Shaneh via GitGitGadget's message of "Sat, 20 Apr 2024 19:51:30 +0000")

"Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
>
>  Documentation/RelNotes/2.45.0.txt | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt
> index 0570dcd8773..38458664407 100644
> --- a/Documentation/RelNotes/2.45.0.txt
> +++ b/Documentation/RelNotes/2.45.0.txt
> @@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc.
>  
>   * The way placeholders are to be marked-up in documentation have been
>     specified; use "_<placeholder>_" to typeset the word inside a pair
> -   of <angle-brakets> emphasized.
> +   of <angle-brackets> emphasized.

Thanks.

> @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
>     clean.requireForce has been simplified, together with the
>     documentation.
>  
> - * The code to iterate over refs with the reftable backend has seen
> -   some optimization.
> -
>   * Uses of xwrite() helper have been audited and updated for better
>     error checking and simpler code.

Interesting.  It is likely that we had two topics that did things
that summarised down to the same description.  They are 

 448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14)
 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)

I do not know which is better between removing the second entry
(which is what this patch is doing, as the entries are in
chronological order of the topics' graduation to 'master'), or
amending it to say "has seen some more optimization".



  reply	other threads:[~2024-04-21 18:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-20 19:51 [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Orgad Shaneh via GitGitGadget
2024-04-21 18:29 ` Junio C Hamano [this message]
2024-04-22  5:51   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqseze1seh.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=orgads@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).