From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Orgad Shaneh <orgads@gmail.com>
Subject: Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog
Date: Mon, 22 Apr 2024 07:51:19 +0200 [thread overview]
Message-ID: <ZiX616G0PPp1jICn@tanuki> (raw)
In-Reply-To: <xmqqseze1seh.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Sun, Apr 21, 2024 at 11:29:10AM -0700, Junio C Hamano wrote:
> "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Orgad Shaneh <orgads@gmail.com>
> >
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> > @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
> > clean.requireForce has been simplified, together with the
> > documentation.
> >
> > - * The code to iterate over refs with the reftable backend has seen
> > - some optimization.
> > -
> > * Uses of xwrite() helper have been audited and updated for better
> > error checking and simpler code.
>
> Interesting. It is likely that we had two topics that did things
> that summarised down to the same description. They are
>
> 448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14)
> 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)
>
> I do not know which is better between removing the second entry
> (which is what this patch is doing, as the entries are in
> chronological order of the topics' graduation to 'master'), or
> amending it to say "has seen some more optimization".
Squashing these into a single entry should be fine in my opinion. The
split was artificial anyway to make the review process easier.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-04-22 5:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 19:51 [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Orgad Shaneh via GitGitGadget
2024-04-21 18:29 ` Junio C Hamano
2024-04-22 5:51 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiX616G0PPp1jICn@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).