From: Junio C Hamano <gitster@pobox.com>
To: Olga Telezhnaya <olyatelezhnaya@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH Outreachy 1/2] format: create pretty.h file
Date: Fri, 08 Dec 2017 12:37:33 -0800 [thread overview]
Message-ID: <xmqqr2s56jn6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <01020160364a23d5-471a2fd0-9fff-4599-86f8-b2f37a4a0a84-000000@eu-west-1.amazonses.com> (Olga Telezhnaya's message of "Fri, 8 Dec 2017 13:21:56 +0000")
Olga Telezhnaya <olyatelezhnaya@gmail.com> writes:
> archive.c | 1 +
> builtin/notes.c | 2 +-
> builtin/reset.c | 2 +-
> builtin/show-branch.c | 2 +-
> combine-diff.c | 1 +
> commit.c | 1 +
> commit.h | 80 ----------------------------------------------
> diffcore-pickaxe.c | 1 +
> grep.c | 1 +
> log-tree.c | 1 +
> notes-cache.c | 1 +
> pretty.h | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++
> revision.h | 2 +-
> sequencer.c | 1 +
> sha1_name.c | 1 +
> submodule.c | 1 +
> 16 files changed, 101 insertions(+), 84 deletions(-)
> create mode 100644 pretty.h
>
> diff --git a/archive.c b/archive.c
> index 0b7b62af0c3ec..60607e8c00857 100644
> --- a/archive.c
> +++ b/archive.c
> @@ -2,6 +2,7 @@
> #include "config.h"
> #include "refs.h"
> #include "commit.h"
> +#include "pretty.h"
> #include "tree-walk.h"
> #include "attr.h"
> #include "archive.h"
This has a toll on topics in flight that expect the symbols for
pretty are available in "commit.h"; they are forced to include
this new file they did not even know about.
I notice that "commit.h" is included in "builtin.h"; perhaps adding
a new include for "pretty.h" there would be of lessor impact? I
dunno.
next prev parent reply other threads:[~2017-12-08 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 13:21 [PATCH Outreachy 1/2] format: create pretty.h file Olga Telezhnaya
2017-12-08 13:21 ` [PATCH Outreachy 2/2] format: create docs for pretty.h Olga Telezhnaya
2017-12-08 19:26 ` Eric Sunshine
2017-12-08 17:40 ` [PATCH Outreachy 1/2] format: create pretty.h file Junio C Hamano
2017-12-10 14:53 ` Jeff King
2017-12-10 22:36 ` Junio C Hamano
2017-12-11 9:58 ` Оля Тележная
2017-12-11 20:43 ` Junio C Hamano
2017-12-08 18:11 ` Eric Sunshine
2017-12-08 20:37 ` Junio C Hamano [this message]
2017-12-09 7:48 ` Оля Тележная
2017-12-12 8:55 ` [PATCH Outreachy v2 " Olga Telezhnaya
2017-12-12 8:55 ` [PATCH Outreachy v2 2/2] format: create docs for pretty.h Olga Telezhnaya
2017-12-12 22:12 ` [PATCH Outreachy v2 1/2] format: create pretty.h file Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2s56jn6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=olyatelezhnaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).