From: Eric Sunshine <sunshine@sunshineco.com>
To: Olga Telezhnaya <olyatelezhnaya@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH Outreachy 2/2] format: create docs for pretty.h
Date: Fri, 8 Dec 2017 14:26:23 -0500 [thread overview]
Message-ID: <CAPig+cSjSHJoBz5rWBZE=AO=XhEk6ZoGkmqiuk_r9PgAe5wt4w@mail.gmail.com> (raw)
In-Reply-To: <01020160364a2471-0e40e237-80b4-485c-a987-9c83206a2ee5-000000@eu-west-1.amazonses.com>
On Fri, Dec 8, 2017 at 8:21 AM, Olga Telezhnaya
<olyatelezhnaya@gmail.com> wrote:
> Write some docs for functions in pretty.h.
> Take it as a first draft, they would be changed later.
>
> Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored by: Jeff King <peff@peff.net>
> ---
> diff --git a/pretty.h b/pretty.h
> @@ -57,31 +58,74 @@ struct userformat_want {
> +/*
> + * Create a text message about commit using given "format" and "context".
> + * Put the result to "sb".
> + * Please use this function for custom formats.
> + */
> void format_commit_message(const struct commit *commit,
> const char *format, struct strbuf *sb,
> const struct pretty_print_context *context);
>
> +/*
> + * Parse given arguments from "arg", check it for correctness and
> + * fill struct rev_info.
To be consistent with the way you formatted the other comments, I
think you'd want quotes around rev_info.
> + */
> void get_commit_format(const char *arg, struct rev_info *);
next prev parent reply other threads:[~2017-12-08 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 13:21 [PATCH Outreachy 1/2] format: create pretty.h file Olga Telezhnaya
2017-12-08 13:21 ` [PATCH Outreachy 2/2] format: create docs for pretty.h Olga Telezhnaya
2017-12-08 19:26 ` Eric Sunshine [this message]
2017-12-08 17:40 ` [PATCH Outreachy 1/2] format: create pretty.h file Junio C Hamano
2017-12-10 14:53 ` Jeff King
2017-12-10 22:36 ` Junio C Hamano
2017-12-11 9:58 ` Оля Тележная
2017-12-11 20:43 ` Junio C Hamano
2017-12-08 18:11 ` Eric Sunshine
2017-12-08 20:37 ` Junio C Hamano
2017-12-09 7:48 ` Оля Тележная
2017-12-12 8:55 ` [PATCH Outreachy v2 " Olga Telezhnaya
2017-12-12 8:55 ` [PATCH Outreachy v2 2/2] format: create docs for pretty.h Olga Telezhnaya
2017-12-12 22:12 ` [PATCH Outreachy v2 1/2] format: create pretty.h file Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSjSHJoBz5rWBZE=AO=XhEk6ZoGkmqiuk_r9PgAe5wt4w@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=olyatelezhnaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).