* [PATCH] fetch: fix compilation warning
@ 2018-09-27 22:08 Ramsay Jones
2018-09-29 18:34 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2018-09-27 22:08 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list
commit 440fc7c0729 ("fetch: replace string-list used as a look-up
table with a hashmap", 2018-09-25) renamed a string-list variable
(while adding a hashmap of the same name) and forgot to rename the
string-list variable in a call to string_list_clear().
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,
You probably already know, but I had to add this on top of the 'pu'
branch to get a clean compile tonight (your 'jc/war-on-string-list'
branch).
Thanks!
ATB,
Ramsay Jones
builtin/fetch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 0a71953bc5..aea2e10364 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -391,7 +391,7 @@ static void find_non_local_tags(const struct ref *refs,
}
}
hashmap_free(&remote_refs, 1);
- string_list_clear(&remote_refs, 0);
+ string_list_clear(&remote_refs_list, 0);
}
static struct ref *get_ref_map(struct remote *remote,
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fetch: fix compilation warning
2018-09-27 22:08 [PATCH] fetch: fix compilation warning Ramsay Jones
@ 2018-09-29 18:34 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2018-09-29 18:34 UTC (permalink / raw)
To: Ramsay Jones; +Cc: GIT Mailing-list
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> You probably already know, but I had to add this on top of the 'pu'
> branch to get a clean compile tonight (your 'jc/war-on-string-list'
> branch).
It was not just about squelching a warning but simply broken code
that deserved to be warned/errored. I think what we have in 'pu'
now is already fixed.
Thanks.
> }
> hashmap_free(&remote_refs, 1);
> - string_list_clear(&remote_refs, 0);
> + string_list_clear(&remote_refs_list, 0);
> }
>
> static struct ref *get_ref_map(struct remote *remote,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-29 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 22:08 [PATCH] fetch: fix compilation warning Ramsay Jones
2018-09-29 18:34 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).