git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: Philip Oakley <philipoakley@iee.email>, git@vger.kernel.org
Subject: Re: [PATCH] myFirstContribition: answering questions is not the end of the story
Date: Mon, 30 Nov 2020 20:46:01 -0800	[thread overview]
Message-ID: <xmqqr1oarv5i.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201124201419.GA3783238@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

>> > +to write is because your patchset needed clarification to be understood.
>> 
>> Perhaps a paragraph break here?
> Agreed.
> ...
> Overall a point I really appreciate having written out here. I think
> it's a good addition to this doc.
>
> Reviewed-by: Emily Shaffer <emilyshaffer@google.com>

Thanks.

  reply	other threads:[~2020-12-01  4:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 17:52 Junio C Hamano
2020-11-20 21:42 ` Philip Oakley
2020-11-20 22:34   ` Junio C Hamano
2020-11-24 20:14   ` Emily Shaffer
2020-12-01  4:46     ` Junio C Hamano [this message]
2020-11-21  2:54 ` Philippe Blain
2020-11-21 21:53   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1oarv5i.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=philipoakley@iee.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).