mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philippe Blain <>
To: Junio C Hamano <>
Cc: Git List <>, Emily Shaffer <>
Subject: Re: [PATCH] myFirstContribition: answering questions is not the end of the story
Date: Fri, 20 Nov 2020 21:54:36 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Junio,

Le ven. 20 nov. 2020, à 21 h 50, Junio C Hamano <> a écrit :
> A review exchange may begin with a reviewer asking "what did you
> mean by this phrase in your log message (or here in the doc)?", the
> author answering what was meant, and then the reviewer saying "ah,
> that is what you meant---then the flow of the logic makes sense".
> But that is not the happy end of the story.  New contributors often
> forget that the material that has been reviewed in the above exchange
> is still unclear in the same way to the next person who reads it,
> until it gets updated.
> While we are in the vicinity, rephrase the verb "request" used to
> refer to comments by reviewers to "suggest"---this matches the
> contrast between "original" and "suggested" that appears later in
> the same paragraph, and more importantly makes it clearer that it is
> not like authors are to please reviewers' wishes but rather
> reviewers are merely helping authors to polish their commits.
> Signed-off-by: Junio C Hamano <>
> ---

I think this is a nice addition. However the patch title should probably
be prefixed "MyFirstContribution" and not "myFirstContribition" ;)



  parent reply	other threads:[~2020-11-21  2:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 17:52 [PATCH] myFirstContribition: answering questions is not the end of the story Junio C Hamano
2020-11-20 21:42 ` Philip Oakley
2020-11-20 22:34   ` Junio C Hamano
2020-11-24 20:14   ` Emily Shaffer
2020-12-01  4:46     ` Junio C Hamano
2020-11-21  2:54 ` Philippe Blain [this message]
2020-11-21 21:53   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).