Re: [PATCH] myFirstContribition: answering questions is not the end of the story

[Philippe Blain <levraiphilippeblain@gmail.com>]

Hi Junio,

Le ven. 20 nov. 2020, à 21 h 50, Junio C Hamano <gitster@pobox.com> a écrit :
>
> A review exchange may begin with a reviewer asking "what did you
> mean by this phrase in your log message (or here in the doc)?", the
> author answering what was meant, and then the reviewer saying "ah,
> that is what you meant---then the flow of the logic makes sense".
>
> But that is not the happy end of the story.  New contributors often
> forget that the material that has been reviewed in the above exchange
> is still unclear in the same way to the next person who reads it,
> until it gets updated.
>
> While we are in the vicinity, rephrase the verb "request" used to
> refer to comments by reviewers to "suggest"---this matches the
> contrast between "original" and "suggested" that appears later in
> the same paragraph, and more importantly makes it clearer that it is
> not like authors are to please reviewers' wishes but rather
> reviewers are merely helping authors to polish their commits.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

I think this is a nice addition. However the patch title should probably
be prefixed "MyFirstContribution" and not "myFirstContribition" ;)

Cheers!

Philippe.