From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>
Subject: Re: [PATCHv2] attr: convert to new threadsafe API
Date: Wed, 12 Oct 2016 13:59:37 -0700 [thread overview]
Message-ID: <xmqqpon52shy.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kaBhXHLDEK0XMLjm3QofmtaGZspA3EEx5x4-qCYY--wZA@mail.gmail.com> (Stefan Beller's message of "Wed, 12 Oct 2016 13:02:40 -0700")
Stefan Beller <sbeller@google.com> writes:
>>> Well all of the hunks in the patch are not threaded, so they
>>> don't follow a threading pattern, but the static pattern to not be
>>> more expensive than needed.
>>
>> Is it too invasive a change to make them as if they are thread-ready
>> users of API that happen to know their callers are not threading?
>> It would be ideal if we can prepare them so that the way they
>> interact with the attr subsystem will not have to change after this
>> step.
>
> As far as I see the future, we do not need to change those in the future,
> unless we add the threading to the current callers, which is usually a very
> invasive thing?
It does not matter how invasive the thread set-up and teardown that
happens in the callers.
I am talking about the part of _THIS_ code that you are updating,
that interacts with attr API. The way they prepare "check" and
"result", the way they ask questions by calling git_check_attr()
function.
Think of a thread-safe library function (like malloc()). If you
write
func (...) {
buf = malloc(20);
...
free(buf);
}
in a function that happens to be only called in a non-threaded
program today, you do not have to update these calls to malloc(3)
and free(3) when you update the callchain to threadable, right?
That kind of thread-preparedness is what I am trying to see if we
can achieve with this update.
next prev parent reply other threads:[~2016-10-12 22:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 23:59 [PATCHv2] attr: convert to new threadsafe API Stefan Beller
2016-10-12 6:12 ` Junio C Hamano
2016-10-12 6:51 ` Stefan Beller
2016-10-12 16:20 ` Junio C Hamano
2016-10-12 20:02 ` Stefan Beller
2016-10-12 20:59 ` Junio C Hamano [this message]
2016-10-12 22:57 ` Junio C Hamano
2016-10-12 20:07 ` Johannes Sixt
2016-10-12 21:38 ` Junio C Hamano
2016-10-12 21:42 ` Stefan Beller
2016-10-12 21:50 ` Junio C Hamano
2016-10-12 21:45 ` Jacob Keller
2016-10-12 21:47 ` Stefan Beller
2016-10-12 21:28 ` Junio C Hamano
2016-10-12 21:39 ` Stefan Beller
2016-10-12 21:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpon52shy.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).