From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>
Subject: Re: [PATCHv2] attr: convert to new threadsafe API
Date: Wed, 12 Oct 2016 14:44:56 -0700 [thread overview]
Message-ID: <xmqq4m4h2qef.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kaQGs_3dhd-yEzaq=CRXGQhbMuN_7FdFY=FeKZ4scmMeQ@mail.gmail.com> (Stefan Beller's message of "Wed, 12 Oct 2016 14:39:17 -0700")
Stefan Beller <sbeller@google.com> writes:
> On Wed, Oct 12, 2016 at 2:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> This version adds the actual thread safety,
>>> that is promised in the documentation, however it doesn't add any optimization,
>>> i.e. it's a single global lock. But as we do not expect contention, that is fine.
>>
>> Because we have to start _somewhere_, I agree it is a good approach
>> to first try the simplest implementation and then optimize later,
>> but is it an agreed consensus that we do not expect contention?
>
> I agree on that. Did you mean this is obvious to the reader?
I meant to say that "But as we do not expect" sounded like a
justification for the approach based on an unwarranted assumption
that is not even the list concensus. I do not think it is obvious
to the reader that there is no need to worry about contention.
It all is outside the log message, so as long as readers understand
what we meant from this discussion, that is OK.
prev parent reply other threads:[~2016-10-12 21:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 23:59 [PATCHv2] attr: convert to new threadsafe API Stefan Beller
2016-10-12 6:12 ` Junio C Hamano
2016-10-12 6:51 ` Stefan Beller
2016-10-12 16:20 ` Junio C Hamano
2016-10-12 20:02 ` Stefan Beller
2016-10-12 20:59 ` Junio C Hamano
2016-10-12 22:57 ` Junio C Hamano
2016-10-12 20:07 ` Johannes Sixt
2016-10-12 21:38 ` Junio C Hamano
2016-10-12 21:42 ` Stefan Beller
2016-10-12 21:50 ` Junio C Hamano
2016-10-12 21:45 ` Jacob Keller
2016-10-12 21:47 ` Stefan Beller
2016-10-12 21:28 ` Junio C Hamano
2016-10-12 21:39 ` Stefan Beller
2016-10-12 21:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4m4h2qef.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).