git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	Git mailing list <git@vger.kernel.org>,
	Norbert Kiesel <nkiesel@gmail.com>
Subject: Re: [PATCH] diff: prefer indent heuristic over compaction heuristic
Date: Thu, 22 Dec 2016 14:43:53 -0800	[thread overview]
Message-ID: <xmqqpokjeg9i.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+P7+xrkp-qiUVmfeLUcaMP-RSDbH4u3vCjVoQN8=mhz25Cd3A@mail.gmail.com> (Jacob Keller's message of "Thu, 22 Dec 2016 13:41:38 -0800")

Jacob Keller <jacob.keller@gmail.com> writes:

>>                 { OPTION_LOWLEVEL_CALLBACK, 0, "compaction-heuristic", NULL, NULL, N_("Use an experimental blank-line-based heuristic to improve diffs"), PARSE_OPT_NOARG, parse_opt_unknown_cb },
>>
>
> The unchanged context line should have its description re-worded to
> something like "Use an experimental heuristic to improve diffs" as it
> no longer uses only blank lines.

Thanks.  The final copy I pushed out has that change.


  reply	other threads:[~2016-12-22 22:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17  0:54 [PATCH] diff: prefer indent heuristic over compaction heuristic Jacob Keller
2016-12-17  1:30 ` Junio C Hamano
2016-12-17  8:02   ` Jacob Keller
2016-12-22 21:12     ` Junio C Hamano
2016-12-22 21:41       ` Jacob Keller
2016-12-22 22:43         ` Junio C Hamano [this message]
2016-12-23  7:22       ` Jeff King
2016-12-23  8:12         ` Jacob Keller
2016-12-23 16:19           ` Jeff King
2016-12-23 17:45             ` Junio C Hamano
2016-12-23 21:17               ` Junio C Hamano
2016-12-23 22:21                 ` Jeff King
2016-12-23 22:23                   ` Jacob Keller
2016-12-24 12:55                 ` Michael Haggerty
2017-04-27 21:17                   ` Stefan Beller
2017-04-28  8:11                     ` Jeff King
2017-04-28  8:40                     ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpokjeg9i.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jacob.keller@gmail.com \
    --cc=nkiesel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).