From: Jeff King <peff@peff.net>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jacob Keller <jacob.e.keller@intel.com>,
Git mailing list <git@vger.kernel.org>,
Norbert Kiesel <nkiesel@gmail.com>
Subject: Re: [PATCH] diff: prefer indent heuristic over compaction heuristic
Date: Fri, 23 Dec 2016 11:19:18 -0500 [thread overview]
Message-ID: <20161223161917.4a352c2wzerj5uyz@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+P7+xrWsCkABzpSkYJ4fb2_JijmUx=Sf4Hgsr6Z+k=_GogE_Q@mail.gmail.com>
On Fri, Dec 23, 2016 at 12:12:13AM -0800, Jacob Keller wrote:
> I actually would prefer that we just say "this is the default now" and
> provide some knob "no-indent-heuristic" or "no-compaction-heuristic"
> and go with that, I think, since I am pretty sure we're all in
> agreement that the heuristic is an improvement in almost every case,
> certainly all the ones we've found. It's at least not worse in any
> case I've seen, and is usually better.
>
> Thoughts? I don't have a super strong opinion about which name we went
> with for the knob.
Yes, I think we should also make --indent-heuristic the default. That's
technically orthogonal to the name, but I agree the name becomes a lot
less important when it is just on by default.
-Peff
next prev parent reply other threads:[~2016-12-23 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 0:54 [PATCH] diff: prefer indent heuristic over compaction heuristic Jacob Keller
2016-12-17 1:30 ` Junio C Hamano
2016-12-17 8:02 ` Jacob Keller
2016-12-22 21:12 ` Junio C Hamano
2016-12-22 21:41 ` Jacob Keller
2016-12-22 22:43 ` Junio C Hamano
2016-12-23 7:22 ` Jeff King
2016-12-23 8:12 ` Jacob Keller
2016-12-23 16:19 ` Jeff King [this message]
2016-12-23 17:45 ` Junio C Hamano
2016-12-23 21:17 ` Junio C Hamano
2016-12-23 22:21 ` Jeff King
2016-12-23 22:23 ` Jacob Keller
2016-12-24 12:55 ` Michael Haggerty
2017-04-27 21:17 ` Stefan Beller
2017-04-28 8:11 ` Jeff King
2017-04-28 8:40 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223161917.4a352c2wzerj5uyz@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=nkiesel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).