From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Christian Hesse <mail@eworm.de>,
Git Mailing List <git@vger.kernel.org>,
Dan Jacques <dnj@chromium.org>
Subject: Re: [PATCH 1/1] perl: fix installing modules from contrib
Date: Mon, 09 Apr 2018 13:54:31 +0900 [thread overview]
Message-ID: <xmqqpo39569k.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <87tvssva2c.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 03 Apr 2018 12:49:47 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>> +perllibdir:
>> + @echo $(perllibdir_SQ)
This use of _SQ variant is fishy, isn't it? Judging from the output
of
$ git grep _SQ Makefile
e.g.
Makefile: $(INSTALL) $^ '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
Makefile: $(INSTALL) $^ '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
Makefile: $(INSTALL) $^ '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
I'd expect that any _SQ variant must be referenced inside a single
quote pair. In fact, that is why a single quote (and nothing else)
in the base variable is replaced with the magic "'\''" sequence,
first stepping out of the current sq context, append a single sq
(escaped with a backslash from the shell), and then stepping back
into another sq context.
I think nobody saw breakage only because they do not have two
consecutive SPs (or any single quote) in their path to $perllibdir.
If we depend on such limitation, there is no point using _SQ
variant, but we already have _SQ variant, let's use it correctly.
next prev parent reply other threads:[~2018-04-09 4:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 9:20 [PATCH 1/1] perl: fix installing modules from contrib Christian Hesse
2018-04-03 10:49 ` Ævar Arnfjörð Bjarmason
2018-04-09 4:54 ` Junio C Hamano [this message]
2018-04-10 13:36 ` [PATCH v2 " Christian Hesse
2018-04-10 21:44 ` Junio C Hamano
2018-04-11 6:51 ` [PATCH v3 " Christian Hesse
2018-04-18 21:44 ` Junio C Hamano
2018-04-19 21:44 ` Christian Hesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpo39569k.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dnj@chromium.org \
--cc=git@vger.kernel.org \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).