From: Christian Hesse <mail@eworm.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Dan Jacques" <dnj@chromium.org>
Subject: Re: [PATCH v3 1/1] perl: fix installing modules from contrib
Date: Thu, 19 Apr 2018 23:44:20 +0200 [thread overview]
Message-ID: <20180419234420.0dd66dce@leda> (raw)
In-Reply-To: <xmqq36zsgpfb.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Junio C Hamano <gitster@pobox.com> on Thu, 2018/04/19 06:44:
> Christian Hesse <mail@eworm.de> writes:
>
> > Commit 20d2a30f (Makefile: replace perl/Makefile.PL with simple make
> > rules) removed a target that allowed Makefiles from contrib/ to get the
> > correct install path. This introduces a new target for main Makefile and
> > fixes installation for Mediawiki module.
> >
> > v2: Pass prefix as that can have influence as well, add single quotes
> > for _SQ variant.
> > v3: Rename target, add to .PHONY.
> >
> > Signed-off-by: Christian Hesse <mail@eworm.de>
> > ---
>
> Thanks for rerolling. I should have made it a bit more clear that
> the say-* thing was merely a personal preference "I would be writing
> it that way if I were doing it", not a "You should write it this way
> when working on this project".
Well, it's you who maintains the code. So I am fine with whatever you
prefer. ;)
> I think .PHONY is still a good idea
> to have, even for only its documentation value (it is unlikely that
> anybody would create a file "perllibdir").
>
> Let me queue this on top of the v2 queued in 'next' as an
> incremental update.
Thanks a lot!
--
Best regards,
Chris
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-19 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 9:20 [PATCH 1/1] perl: fix installing modules from contrib Christian Hesse
2018-04-03 10:49 ` Ævar Arnfjörð Bjarmason
2018-04-09 4:54 ` Junio C Hamano
2018-04-10 13:36 ` [PATCH v2 " Christian Hesse
2018-04-10 21:44 ` Junio C Hamano
2018-04-11 6:51 ` [PATCH v3 " Christian Hesse
2018-04-18 21:44 ` Junio C Hamano
2018-04-19 21:44 ` Christian Hesse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419234420.0dd66dce@leda \
--to=mail@eworm.de \
--cc=avarab@gmail.com \
--cc=dnj@chromium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).