From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: write fetched refs to .promisor
Date: Thu, 05 Sep 2019 10:13:24 -0700 [thread overview]
Message-ID: <xmqqpnker7ij.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190905070153.GE21450@sigill.intra.peff.net> (Jeff King's message of "Thu, 5 Sep 2019 03:01:53 -0400")
Jeff King <peff@peff.net> writes:
> But I wonder if it would make sense to keep a cache of these "cut
> points" in the partial clone. That's potentially smaller than the
> complete set of objects (especially for tree-based partial cloning), and
> it seems clear we're willing to store it in memory anyway.
That sounds in line with how "shallow" gives us cut points in the
history, but then would we end up listing a handful of cut-point
objects for each and every commit in the history? That still may be
a lot cheaper than computing the same set of cut-point objects every
time, though.
> And if we do that, would the .promisor file for a pack be a good place
> to store it?
>
> -Peff
next prev parent reply other threads:[~2019-09-05 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 21:47 [PATCH] fetch-pack: write fetched refs to .promisor Jonathan Tan
2019-08-27 20:27 ` Junio C Hamano
2019-08-27 21:50 ` Jonathan Tan
2019-09-05 7:01 ` Jeff King
2019-09-05 17:13 ` Junio C Hamano [this message]
2019-09-05 17:59 ` Jeff King
2019-09-05 18:39 ` Jonathan Tan
2019-10-02 16:03 ` Jeff King
2019-10-14 22:27 ` Josh Steadmon
2019-10-14 23:56 ` Jonathan Tan
2019-10-15 0:12 ` [PATCH v2] " Jonathan Tan
2019-10-15 19:40 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnker7ij.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).