From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: write fetched refs to .promisor
Date: Tue, 27 Aug 2019 13:27:30 -0700 [thread overview]
Message-ID: <xmqqmufu2w25.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190826214737.164132-1-jonathantanmy@google.com> (Jonathan Tan's message of "Mon, 26 Aug 2019 14:47:37 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
> As written in the NEEDSWORK comment, repack does not preserve the
> contents of .promisor files, but I thought I'd send this out anyway as
> this change is already useful for users who don't run repack much.
What do you exactly mean by "much" here? The comment sounds like it
is saying "running this code once and you'd make the commits and
objects that were depending on the existing promisor invalid", in
which case it would be more like "it is already useful for users
until they run their first repack that destroyes their repository",
but certainly that is not what we want to do, so...
> +test_expect_success 'verify that .promisor file contains refs fetched' '
> + ls pc1/.git/objects/pack/pack-*.promisor >promisorlist &&
> + test_line_count = 1 promisorlist &&
> + git -C srv.bare rev-list HEAD >headhash &&
> + grep "$(cat headhash) HEAD" $(cat promisorlist) &&
> + grep "$(cat headhash) refs/heads/master" $(cat promisorlist)
> +'
> +
> # checkout master to force dynamic object fetch of blobs at HEAD.
> test_expect_success 'verify checkout with dynamic object fetch' '
> git -C pc1 rev-list --quiet --objects --missing=print HEAD >observed &&
next prev parent reply other threads:[~2019-08-27 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 21:47 [PATCH] fetch-pack: write fetched refs to .promisor Jonathan Tan
2019-08-27 20:27 ` Junio C Hamano [this message]
2019-08-27 21:50 ` Jonathan Tan
2019-09-05 7:01 ` Jeff King
2019-09-05 17:13 ` Junio C Hamano
2019-09-05 17:59 ` Jeff King
2019-09-05 18:39 ` Jonathan Tan
2019-10-02 16:03 ` Jeff King
2019-10-14 22:27 ` Josh Steadmon
2019-10-14 23:56 ` Jonathan Tan
2019-10-15 0:12 ` [PATCH v2] " Jonathan Tan
2019-10-15 19:40 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmufu2w25.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).